Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_component関数の引数の不具合修正 #1125

Closed
wants to merge 1 commit into from

Conversation

Nobu19800
Copy link

Identify the Bug

Description of the Change

  • manager_name/manager_addressが?の後ろで設定してあっても正常に機能するように、一旦パラメータのキーと値を全て取り出して引数文字列を再生成するように変更した。
  • コンポーネント名が空の場合にcreate_component関数を途中で終了するように変更した。
    • 例えば、?manager_name=manager_51510&instance_name=hogemunyaという文字列の場合
  • urlparam2map関数で、コンポーネント名のみの文字列(例えばConsoleIn)を入力した場合に、{ConsoleIn: }と言うようにコンポーネント名をキー、空の文字列を値とする配列を返すため、=が無い場合は無視するように修正した。

Verification

  • Did you succeed the build?
  • No warnings for the build?
  • Have you passed the unit tests?

@Nobu19800 Nobu19800 added the bug Something isn't working label Oct 17, 2023
@Nobu19800 Nobu19800 requested a review from n-ando October 17, 2023 10:21
@Nobu19800 Nobu19800 self-assigned this Oct 17, 2023
@Nobu19800 Nobu19800 closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant