feat: upgrade k8s gateway version from v1alpha2 to v1beta1 #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Qustion: why are the hostname values in the gateways listeners static? (*.ofn.io and *.example.com). According to the proposal, the hostnames should be generated from a variable. |
Signed-off-by: Abdullah Alaqeel <[email protected]>
aqeelat
force-pushed
the
update-gateway-version
branch
from
0b8a5e2
to
6ea1458
Compare
|
@benjaminhuo can you please take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #62
After reviewing the CRDs, I think we can also upgrade https://github.com/OpenFunction/charts/blob/main/openfunction/crds/gateway-api.yaml to include v1. That could be in another PR though.