Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][mig] passport_expiration #60

Open
wants to merge 11 commits into
base: 15.0
Choose a base branch
from
Open

[15.0][mig] passport_expiration #60

wants to merge 11 commits into from

Conversation

damdam-s
Copy link
Member

No description provided.

yankinmax
yankinmax approved these changes Jun 30, 2022
View reviewed changes
passport_expiration/models/hr.py Outdated Show resolved Hide resolved
@damdam-s damdam-s force-pushed the 15.0-mig-passport_expiration branch from 8d92fc2 to 45c7fe1 Compare June 30, 2022 09:07
leemannd
leemannd approved these changes Aug 4, 2022
View reviewed changes
Copy link

@leemannd leemannd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration is technically legit.
I'm currently wondering if it shouldn't be moved to the repo OCA/hr.
This vertical-travel repository seems not much alive and adding a field on the employee is a module that I'll be looking into hr.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk
Copy link

simahawk commented Feb 1, 2023

can you rebase?

Migration is technically legit. I'm currently wondering if it shouldn't be moved to the repo OCA/hr. This vertical-travel repository seems not much alive and adding a field on the employee is a module that I'll be looking into hr.

Seems more partner-contact-ish no?

@leemannd
Copy link

leemannd commented Feb 2, 2023

Added on the models and views of the hr.employee. So for me definitely hr related.
But the most important for me would be to have it into a repo that is more used and where it could be seen and used.

@yankinmax
Copy link

@leemannd let me close this one and add this module to hr?

@yankinmax yankinmax mentioned this pull request Mar 29, 2024
Merged
1 task
@yankinmax
Copy link

Superseded by:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leemannd leemannd leemannd approved these changes

@yankinmax yankinmax yankinmax approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@damdam-s @OCA-git-bot @simahawk @leemannd @yankinmax @gurneyalex @oca-travis