-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] stock_quantity_history_location #316
base: 17.0
Are you sure you want to change the base?
[17.0][MIG] stock_quantity_history_location #316
Conversation
… on Account Valuation
Currently translated at 100.0% (4 of 4 strings) Translation: stock-logistics-reporting-13.0/stock-logistics-reporting-13.0-stock_quantity_history_location Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-13-0/stock-logistics-reporting-13-0-stock_quantity_history_location/ro/
Currently translated at 100.0% (4 of 4 strings) Translation: stock-logistics-reporting-13.0/stock-logistics-reporting-13.0-stock_quantity_history_location Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-13-0/stock-logistics-reporting-13-0-stock_quantity_history_location/it/
… re-use by othher addons
…rors according to stock_account_quantity_history_location
Currently translated at 100.0% (6 of 6 strings) Translation: stock-logistics-reporting-14.0/stock-logistics-reporting-14.0-stock_quantity_history_location Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-14-0/stock-logistics-reporting-14-0-stock_quantity_history_location/ja/
Co-authored-by: DavidJForgeFlow <[email protected]>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-reporting-15.0/stock-logistics-reporting-15.0-stock_quantity_history_location Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-15-0/stock-logistics-reporting-15-0-stock_quantity_history_location/
Currently translated at 60.0% (3 of 5 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_quantity_history_location Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_quantity_history_location/it/
This commit solves the error "Non loaded module stock_quantity_history_location.InventoryReportListController" because the dependency stock.InventoryReportListController was missed. The dependency from stock was migrated to OWL [1], so it is inherited using the OWL to preserve the behavior. References: - [1] odoo/odoo@ec0b1005
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_quantity_history_location Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_quantity_history_location/
Currently translated at 100.0% (5 of 5 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_quantity_history_location Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_quantity_history_location/it/
Currently translated at 100.0% (5 of 5 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_quantity_history_location Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_quantity_history_location/es/
61344a9
to
1efe2c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the rest, functional and code review LGTM 👍🏿
stock_quantity_history_location/wizards/stock_quantity_history.xml
Outdated
Show resolved
Hide resolved
1efe2c6
to
760f848
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review
/ocabot migration stock_quantity_history_location |
|
||
@api.model | ||
def get_views(self, views, options=None): | ||
res = super().get_views(views, options=options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnaisLForgeFlow Maybe a good improvement should be adding a little test calling the view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rousseldenis sure, we can add this for better test coverage
Standard Migration
@ForgeFlow