Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] report_csv: Assign 'reportname' variable before accessing it #773

Merged
merged 3 commits into from
Jul 14, 2023
Merged

[FIX] report_csv: Assign 'reportname' variable before accessing it #773

merged 3 commits into from
Jul 14, 2023

Conversation

rousseldenis
Copy link
Sponsor Contributor

@rousseldenis
Copy link
Sponsor Contributor Author

@adrienpeiffer In addition of this fix, shouldn't an error re-raise werkzeug InternalServerError instead ?

Like this : https://github.com/odoo/odoo/blob/16.0/addons/stock/controllers/main.py#L38

AnizR
AnizR approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@AnizR AnizR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@adrienpeiffer
Copy link
Contributor

@rousseldenis Totally agree with you !

@rousseldenis
Copy link
Sponsor Contributor Author

rousseldenis commented Jun 27, 2023 •
edited
Loading

@adrienpeiffer @AnizR @ioans73 In addition, I've added the InternalServerError return and a test for controller to increase coverage

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@thomaspaulb
Copy link

/ocabot merge patch

1 similar comment
@thomaspaulb
Copy link

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-773-by-thomaspaulb-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fbb9ab4 into OCA:16.0 Jul 14, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c024599. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioans73 ioans73 ioans73 approved these changes

@AnizR AnizR AnizR approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rousseldenis @adrienpeiffer @OCA-git-bot @thomaspaulb @ioans73 @AnizR