Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] migration_pr_check: Remind migration guidelines #220

Closed
wants to merge 1 commit into from

Conversation

SirTakobi
Copy link
Contributor

@SirTakobi SirTakobi commented Oct 11, 2022

Possible implementation of #159: this always adds a comment about migration guidelines when the PR is identified as a migration PR.

The result is in SirTakobi/l10n-italy#28

@SirTakobi SirTakobi marked this pull request as ready for review October 11, 2022 12:46
@legalsylvain
Copy link
Collaborator

Hi @SirTakobi
just reviewed your code. LGTM. Just one question : to know if a PR is a migration one, you parse the related issue. That's great but in my opinion not complete. i think we could also guess it's a migration PR if the title contains "[MIG]" or " mig ". (many times, the issue "Migration in version 16.0" is not updated.

What do you think ?

@SirTakobi SirTakobi marked this pull request as draft February 7, 2023 15:16
@SirTakobi SirTakobi force-pushed the imp-issue159 branch 2 times, most recently from 7eaf963 to 0aa668c Compare February 7, 2023 15:48
@SirTakobi
Copy link
Contributor Author

Hi @SirTakobi just reviewed your code. LGTM. Just one question : to know if a PR is a migration one, you parse the related issue. That's great but in my opinion not complete. i think we could also guess it's a migration PR if the title contains "[MIG]" or " mig ". (many times, the issue "Migration in version 16.0" is not updated.

What do you think ?

Thanks for having a look!
I added a check on the PR Title with its test; it is mocking more than I'd like to, but I think there is no other way to make it work.
I also fixed a false positive in another test.

pre-commit is failing while building isort's virtual Environment, I suppose it will be fixed after #229

@SirTakobi SirTakobi marked this pull request as ready for review February 7, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants