[14.0][FIX] fleet_vehicle_log_fuel: Don't replace whole SQL view + make it work + renaming (backport) #139
+66
−163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please cherry-pick whole commit instead, adapting it to the 14.0 SQL. This way, it works, but replacing every other possible adaptation in other third-party modules. Let's do things right. |
MiquelRForgeFlow
force-pushed
the
14.0-fix-fleet_vehicle_log_fuel
branch
from
b378e28
to
eb07d77
Compare
MiquelRForgeFlow
changed the title
MiquelRForgeFlow
force-pushed
the
14.0-fix-fleet_vehicle_log_fuel
branch
from
eb07d77
to
822f552
Compare
…work + renaming Replacing whole SQL view definition is totally incompatible with other modules adding things to this report. We use a trick for replacing only some parts retrieving the current SQL view for keeping the inheritability. We need as well to add the new selection value. Finally, a renaming of the model file for proper recognition has been done. TT48062
MiquelRForgeFlow
force-pushed
the
14.0-fix-fleet_vehicle_log_fuel
branch
from
822f552
to
1bff188
Compare
pedrobaeza
approved these changes
Mar 1, 2024
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at bf2a66c. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #138.