Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] delivery_price_method: Migration to 14.0 #518

Merged
merged 15 commits into from
Aug 11, 2022
Merged

[14.0][MIG] delivery_price_method: Migration to 14.0 #518

merged 15 commits into from
Aug 11, 2022

Conversation

victoralmau
Copy link
Member

Superseed: #486

Migration to 14.0

Please @pedrobaeza and @chienandalu can you review it?

@Tecnativa TT36947

rlizana and others added 15 commits August 11, 2022 17:46
@rlizana @victoralmau
[ADD] delivery_price_method
33090ef
@pedrobaeza @victoralmau
[IMP] delivery_price_method: Make it independent + more compatible
d248728 
- Add default price_method called "Carrier obtained price", for being more explicit
  and avoid user confusions.
- Shipment rate: Make it compatible with upstream code tricking the delivery_type
  field.
- Shipping sending: Call upstream carrier sending routine + call standard one, and
  merge results (excluding the tracking_number).
- Tests:

  * Make them more resilient (fixing the pricelist).
  * Use SavepointCase for executing setup only once.
  * Fine tune some code
- Improve README
@oca-travis @victoralmau
[UPD] Update delivery_price_method.pot
97280f5
@OCA-git-bot @victoralmau
[ADD] icon.png
87a16a3
@misern2 @victoralmau
[IMP] delivery_price_method: black, isort, prettier
53a0107
@misern2 @victoralmau
[MIG] delivery_price_method: Migration to 13.0
1623f89 
[UPD] Update delivery_price_method.pot

[UPD] README.rst
@chienandalu @victoralmau
[FIX] delivery_price_method: method permissions
6537bd2 
If a user don't have the necessary permissions for writing in the
`delivery.carrier` model (like a low range salesman) he won't be able to
choose a carrier wich uses the rate shipment override.

TT31627

delivery_price_method 13.0.1.0.1
@pedrobaeza @victoralmau
[IMP] delivery_*: Promote modules to Stable
83fae64 
[UPD] README.rst

delivery_price_method 13.0.1.0.2
@macagua @victoralmau
Added translation using Weblate (Spanish)
0d43612
@macagua @victoralmau
Added translation using Weblate (Spanish (Chile))
9f82e7c
@macagua @victoralmau
Added translation using Weblate (Spanish (es_VE))
34dfd09
@macagua @victoralmau
Translated using Weblate (Spanish)
6a1d35b 
Currently translated at 100.0% (6 of 6 strings)

Translation: delivery-carrier-13.0/delivery-carrier-13.0-delivery_price_method
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-13-0/delivery-carrier-13-0-delivery_price_method/es/
@macagua @victoralmau
Translated using Weblate (Spanish (Chile))
231f0c3 
Currently translated at 100.0% (6 of 6 strings)

Translation: delivery-carrier-13.0/delivery-carrier-13.0-delivery_price_method
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-13-0/delivery-carrier-13-0-delivery_price_method/es_CL/
@victoralmau
[IMP] delivery_price_method: black, isort, prettier
3b03168
@victoralmau
[MIG] delivery_price_method: Migration to 14.0
eda40a5 
TT36947
@victoralmau victoralmau mentioned this pull request Aug 11, 2022
Closed
@pedrobaeza
Copy link
Member

@vicentecom can you review this one instead?

@pedrobaeza
Copy link
Member

/ocabot migration delivery_price_method

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone Aug 11, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 11, 2022
Open
21 tasks
@OCA-git-bot
Copy link
Contributor

The migration issue (#297) has been updated to reference the current pull request.
however, a previous pull request was referenced : #486.
Perhaps you should check that there is no duplicate work.
CC : @vicentecom

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-518-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 11, 2022
@OCA-git-bot
Merge PR #518 into 14.0
6f6e85d 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-518-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a1b0543 into OCA:14.0 Aug 11, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e00794e. Thanks a lot for contributing to OCA. ❤️

@victoralmau victoralmau mentioned this pull request Aug 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@hildickethan hildickethan hildickethan approved these changes

@cesar-tecnativa cesar-tecnativa cesar-tecnativa approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
10 participants
@victoralmau @pedrobaeza @OCA-git-bot @hildickethan @cesar-tecnativa @rlizana @oca-travis @misern2 @chienandalu @macagua