Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG]account_fiscal_position_autodetect_optional_vies: Migration to 17.0 #411

Conversation

Tisho99
Copy link
Contributor

@Tisho99 Tisho99 commented Feb 22, 2024

The optional vies field is now part of the core of Odoo. So, changes have been done assuming base_vat_optional_vies is not going to be migrated to 17.0

victoralmau and others added 14 commits February 16, 2024 12:17
…dds vat VIES validation to fiscal positions.

TT30631
… type in test partner

After OCA/OCB@4518968#diff-1ef5fe83935572c9b9b9e6eec69a44551023f3b92fe38bed4f765a24e16694b4 and OCA/OCB@198a4dd the associated partner needs to be of type `company` for the vies check to work.

@Tecnativa
…n contacts

Steps to reproduce the problem:

- Create a partner with a proper VIES VAT.
- Create a children for that partner.
- Create a fiscal position with "Vat was VIES validated" and
  "Auto-apply" marks checked.
- Use the children partner in an invoice.

Current behavior:

The fiscal position is not selected.

Expected behavior:

The fiscal position is selected.

TT38107
@Tisho99 Tisho99 marked this pull request as draft February 22, 2024 10:55
@Tisho99 Tisho99 mentioned this pull request Feb 22, 2024
10 tasks
@Tisho99 Tisho99 force-pushed the 17.0-mig-account_fiscal_position_autodetect_optional_vies branch from a46563d to 7ee159e Compare February 22, 2024 12:42
@Tisho99 Tisho99 marked this pull request as ready for review February 22, 2024 12:47
@Tisho99
Copy link
Contributor Author

Tisho99 commented Feb 22, 2024

@ValentinVinagre

@ValentinVinagre
Copy link
Contributor

@Jesarregui @HaraldPanten could u review please?

Copy link
Contributor

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@HaraldPanten
Copy link
Contributor

/ocabot migration account_fiscal_position_autodetect_optional_vies

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Feb 28, 2024
@HaraldPanten
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-411-by-HaraldPanten-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ccf02aa into OCA:17.0 Feb 29, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 21aa424. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 17.0-mig-account_fiscal_position_autodetect_optional_vies branch February 29, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants