Addressing PR comments for Transitives in Solution PM UI #6064
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jebriede
reviewed
Sep 27, 2024
...ts/NuGet.PackageManagement.VisualStudio.Test/Feeds/InstalledAndTransitivePackageFeedTests.cs
Outdated
Show resolved
Hide resolved
| @@ -237,7 +237,7 @@ public async Task SearchAsync_WhenMultitargetingAndEmptySearch_ReturnsOnePackage | |||
| e => Assert.Equal(new PackageIdentity("packageC", new NuGetVersion("2.0.0")), e.Identity), | |||
| // Returns latest transitive package version | |||
| e => Assert.Equal(new PackageIdentity("transitivePackageC", new NuGetVersion("0.0.2")), e.Identity), | |||
| // Returns all the transtive packages that are not the latest verion | |||
| // Returns all the transitive packages that are not the latest version | |||
There was a problem hiding this comment.
Please also add the extra context and explanation of why we are getting all the transitive packages except the latest version, as requested in this comment: #6044 (comment)
There was a problem hiding this comment.
Oops I don't know how the commit didn't include the comment I added
There was a problem hiding this comment.
There is nothing special about transitive's. The same assert is being done for top-level packages.
From Donnie comment
If they are sorted, why is transitivePackageC 0.0.2 asserted before version 0.0.1 ?
Packages are sorted using SemVer so 0.0.2 is newer than 0.0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13216
Description
Addressing feedback and comments from the original pull request for the Transitive Packages in Solution PM UI feature: #6044 (comment).
PR Checklist
[ ] Added testsNo tests needed, just addressing some minor fixes