Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry for HTTP resources that have an HTTPS source #6022

Closed
wants to merge 5 commits into from

Conversation

Nigusu-Allehu
Copy link
Contributor

@Nigusu-Allehu Nigusu-Allehu commented Sep 10, 2024

Bug

Fixes: NuGet/Home#13744

Description

This PR adds telemetry for service index resources that are HTTP, but the sources is HTTPS.
for example a v3 source with the following index would end up using a non https service endpoint.

{
    "version": "3.0.0",
    "resources": [
        {
            "@id": "http://source",
            "@type": "SearchQueryService",
            "comment": "Query endpoint of NuGet Search service (primary)"
        }]
}

This telemetry will allow us to count how many resources are HTTP (just like the search resource above) but have an HTTPS source.

Key Purpose
NumHTTPDownloadResourceWithHTTPSSource Counts download resources that are HTTP but have an HTTPS source
NumHTTPOwnerDetailsUriResourceWithHTTPSSource Counts Owner details Uri resources ...
NumHTTPPackageDetailsUriResourceWithHTTPSSource Counts Package Details Uri resources..

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@Nigusu-Allehu Nigusu-Allehu requested a review from a team as a code owner September 10, 2024 23:52
@Nigusu-Allehu Nigusu-Allehu marked this pull request as draft September 10, 2024 23:52
@Nigusu-Allehu Nigusu-Allehu self-assigned this Sep 10, 2024
@dotnet-policy-service dotnet-policy-service bot added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Sep 19, 2024
@nkolev92 nkolev92 added the Merge next release PRs that should not be merged until the dev branch targets the next release label Sep 19, 2024
@dotnet-policy-service dotnet-policy-service bot removed the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Sep 19, 2024
@aortiz-msft aortiz-msft removed the Merge next release PRs that should not be merged until the dev branch targets the next release label Sep 24, 2024
@Nigusu-Allehu
Copy link
Contributor Author

Closing in favor of #6047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect telemetry for HTTPS sources with HTTP resources
3 participants