Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all occurences of IDE0055 code style formatting rule violations #5978

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

4creators
Copy link

@4creators 4creators commented Aug 16, 2024

… fix local repo and source build builds

Bug

Fixes:
Build failures caused by code style violations raising IDE0055 warning described in issue #13714

Description

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@4creators 4creators requested a review from a team as a code owner August 16, 2024 10:18
@dotnet-policy-service dotnet-policy-service bot added the Community PRs created by someone not in the NuGet team label Aug 16, 2024
@kartheekp-ms
Copy link
Contributor

kartheekp-ms commented Aug 22, 2024

I am unable to reproduce the build errors reported in NuGet/Home#13714 locally. We fail builds on our CI if there are formatting errors in the code. So far, both local (on CLI and VS) and CI builds haven't complained about these formatting issues. Please let me know if I am missing something while trying to reproduce these failures locally.

❯ ./build.ps1 -Configuration Release -SkipUnitTest
[16:23:04 +0]   ============================================================
[16:23:04 +0]   Build started at 08/22/2024 23:23:04
[16:23:04 +0]   [BEGIN] Cleaning artifacts
[16:23:04 +0]   Cleaning the Artifacts folder
[16:23:09 +4]   [DONE +00:00:04] Cleaning artifacts
[16:23:09 +0]   [BEGIN] Running Restore
[16:23:09 +0]   . "msbuild.exe" build\build.proj /t:RestoreVS /p:Configuration=Release /p:ReleaseLabel=zlocal /p:IncludeApex=False /v:m /m
MSBuild version 17.12.0-preview-24415-04+f422d8d7d for .NET Framework

  Restoring
  Determining projects to restore...
  // restore logs
  All projects are up-to-date for restore.

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:10.64
[16:23:19 +11]  [DONE +00:00:10] Running Restore
[16:23:19 +0]   [BEGIN] Running Build
[16:23:19 +0]   . "msbuild.exe" build\build.proj /t:BuildVS;Pack /p:Configuration=Release /p:ReleaseLabel=zlocal /p:IncludeApex=False /v:m /m
MSBuild version 17.12.0-preview-24415-04+f422d8d7d for .NET Framework
Building
// build logs

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:04:26.17
[16:27:46 +266] [DONE +00:04:26] Running Build
WARNING: [16:27:46 +0] [SKIP] Creating the EndToEnd test package
WARNING: [16:27:46 +0] [SKIP] Running Restore RTM
WARNING: [16:27:46 +0] [SKIP] Packing RTM
[16:27:46 +0]   Build #0 ended at 08/22/2024 23:27:46
[16:27:46 +0]   Time elapsed 00:04:41
[16:27:46 +0]   ============================================================

@dotnet-policy-service dotnet-policy-service bot added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Aug 29, 2024
@nkolev92 nkolev92 added the Merge next release PRs that should not be merged until the dev branch targets the next release label Sep 19, 2024
@dotnet-policy-service dotnet-policy-service bot removed the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Sep 19, 2024
@dotnet-policy-service dotnet-policy-service bot added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Sep 27, 2024
@nkolev92 nkolev92 removed the Merge next release PRs that should not be merged until the dev branch targets the next release label Sep 27, 2024
@dotnet-policy-service dotnet-policy-service bot removed the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PRs created by someone not in the NuGet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants