Refactor/replace shuffle commercial provider script #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove deprecation - Remove unused `rec`
drupol
force-pushed
the
refactor/replace-shuffle-commercial-provider-script-june-2023
branch
from
5df7756
to
d67eb99
Compare
This was referenced Jun 27, 2023
fricklerhandwerk
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Merging this as it has been extensively reviewed. We can fix forward if there are still issues. @garbas would be great if we could prune the commit log. I'm not sure if I have push access to master, but if you give green light I'll do it.
drupol
deleted the
refactor/replace-shuffle-commercial-provider-script-june-2023
branch
This was referenced Jun 27, 2023
Mic92
reviewed
Oct 30, 2023
| </li> | ||
|
|
||
| <li> | ||
| <a href="https://nixos.mayflower.consulting"> |
There was a problem hiding this comment.
This does not look correct, fixed in #1140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new PR:
I have to admit that developing the least thing in this project is a nightmare, there's a process which is continuously building SVGs, it never stops. Rendering a simple page takes more than a minute.
I tried to find the root issue causing this, but I couldn't find anything. I'm pretty sure there are room for improvements. (issue opened at #1082 )