Terraform cleanups #459
Merged
Terraform cleanups #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Mic92
commented
Aug 18, 2024
•
Mic92
commented
Makes it easier to tell flake-modules from other files.
also switch to opentofu to avoid unfree package evaluation
Since we manage terraform plugins with nix, we don't need these lock files to pin modules.
Mic92
force-pushed
the
terraform-iam-cleanups
branch
2 times, most recently
from
c02fe45
to
89dbf77
Compare
Mic92
commented
Aug 18, 2024
| p.netlify | ||
| p.secret | ||
| ] ++ [ | ||
| # FIXME: for our `terraform` target our state file still uses the old registry prefix |
There was a problem hiding this comment.
I want to patch the state after this pull request is merged to not break the existing setup.
our terraform targets are similar enough that we can just share devShell between them
we use nix for pinning instead.
Mic92
force-pushed
the
terraform-iam-cleanups
branch
from
89dbf77
to
cd9350e
Compare
zimbatm
approved these changes
Aug 18, 2024
|
|
||
| cd "$(dirname "$0")" | ||
| rm -f .terraform.lock.hcl | ||
| tofu init |
There was a problem hiding this comment.
Doesn't this slow down each terraform invocation?
|
Agreed. It would also make it easier to split up targets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.