-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
non-critical-infra/backup: init and configure on caliban #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
reviewed
Jan 29, 2024
mweinelt
force-pushed
the
backup-module
branch
from
January 29, 2024 15:37
e90385c
to
7c0e06b
Compare
Looks like it can't be called interactively, but borg still manages to connect. |
Works.
|
mweinelt
force-pushed
the
backup-module
branch
from
January 29, 2024 15:50
7c0e06b
to
579dcc0
Compare
This was referenced Jan 29, 2024
JulienMalka
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Module wrapping borgbackup with reasonable defaults and some extras.
mweinelt
force-pushed
the
backup-module
branch
from
January 30, 2024 01:52
579dcc0
to
046d9c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a backup module, encapsulating borgbackup, and configures the storagebox we have for caliban.nixos.org.
The backup module will not be enabled until any path is added in to
services.backup.includes
, but I tested it, and it works.