-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lido-Exporter app #411
Conversation
Updates: - Strengthen client validation - Allow providing a list of RPC endpoints
6c43d24
to
b53a947
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #411 +/- ##
============================================
- Coverage 88.06% 44.34% -43.73%
============================================
Files 99 114 +15
Lines 5673 9797 +4124
============================================
- Hits 4996 4344 -652
- Misses 553 4991 +4438
- Partials 124 462 +338
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We should add documentation either on this PR or in other, about this new app |
Changes:
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?
Further comments (optional)
Since there are two apps in the repo now, we have to create a PR after merging this to move app-specific packages to the app folder (the lido-exporter app has its own
cli
folder for example). Thee2e
folder is respecting this new structure and there is a suite implementation for each app (sedge and lido-exporter).#406 updates sedge's e2e test suite and test cases. The CI will likely fail for this PR since some critical changes and fixes are in #406.