Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lido-Exporter app #411

Merged
merged 34 commits into from
Sep 19, 2024
Merged

Add Lido-Exporter app #411

merged 34 commits into from
Sep 19, 2024

Conversation

AntiD2ta
Copy link
Member

@AntiD2ta AntiD2ta commented Sep 12, 2024

Changes:

  • Add new application lido-exporter to scrape data from Lido CSM smart contracts and export it as Prometheus metrics.
  • Refactor E2E test suite
  • Add interaction code for the VEBO contract
  • Remove courtney dependency (it is better to rely on real test coverage and we are not really using the tool features to hide code)

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Further comments (optional)

Since there are two apps in the repo now, we have to create a PR after merging this to move app-specific packages to the app folder (the lido-exporter app has its own cli folder for example). The e2e folder is respecting this new structure and there is a suite implementation for each app (sedge and lido-exporter).

#406 updates sedge's e2e test suite and test cases. The CI will likely fail for this PR since some critical changes and fixes are in #406.

@AntiD2ta AntiD2ta added enhancement New feature or request go Pull requests that update Go code labels Sep 12, 2024
@AntiD2ta AntiD2ta self-assigned this Sep 12, 2024
@AntiD2ta AntiD2ta marked this pull request as ready for review September 15, 2024 13:22
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 17.64706% with 252 lines in your changes missing coverage. Please review.

Project coverage is 44.34%. Comparing base (000cc79) to head (2ecb064).

Files with missing lines Patch % Lines
cmd/lido-exporter/cli/lido_exporter.go 0.00% 92 Missing ⚠️
cmd/lido-exporter/metrics/metrics.go 0.00% 41 Missing ⚠️
cmd/lido-exporter/metrics/penalties.go 0.00% 31 Missing ⚠️
cmd/lido-exporter/metrics/exit_requests.go 0.00% 18 Missing ⚠️
cmd/lido-exporter/metrics/keys.go 0.00% 16 Missing ⚠️
cmd/lido-exporter/metrics/bonds.go 0.00% 15 Missing ⚠️
cmd/lido-exporter/metrics/node_operator.go 0.00% 14 Missing ⚠️
cmd/lido-exporter/metrics/rewards.go 0.00% 12 Missing ⚠️
cmd/lido-exporter/main.go 0.00% 6 Missing ⚠️
configs/networks.go 58.33% 5 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #411       +/-   ##
============================================
- Coverage    88.06%   44.34%   -43.73%     
============================================
  Files           99      114       +15     
  Lines         5673     9797     +4124     
============================================
- Hits          4996     4344      -652     
- Misses         553     4991     +4438     
- Partials       124      462      +338     
Flag Coverage Δ
unittests 44.34% <17.64%> (-43.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
cmd/lido-exporter/README.md Outdated Show resolved Hide resolved
configs/public_rpcs.go Outdated Show resolved Hide resolved
@stdevMac
Copy link
Member

We should add documentation either on this PR or in other, about this new app

@khalifaa55 khalifaa55 merged commit b63e1f2 into develop Sep 19, 2024
10 checks passed
@khalifaa55 khalifaa55 deleted the feat/lido-exporter branch September 19, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants