add changes for flat encoding #7516
Conversation
Requesting for re-review, addressed this issue in the latest commits |
https://eips.ethereum.org/EIPS/eip-7685#execution-layer |
Sounds like something our RlpDecoder infrastructure could support, add decoder for external list, and then call internal decoders for decoding items dependent on type. No byte array allocation needed, everything done on one pooled buffer through NettyRlpStream |
| int requestsLength = rlpStream.ReadSequenceLength(); | ||
| int requestsCheck = rlpStream.Position + requestsLength; | ||
| // read an array of byte arrays | ||
| byte[][] requestsEncoded = rlpStream.DecodeByteArrays(); |
There was a problem hiding this comment.
unneeded, make it lazy, call internal decoders based on type and progressing the stream
|
PR description! |
will add |
Resolves #7522
Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.