fix not completing the writing of the JsonRPC response (#7146)

NethermindEth · Jun 6, 2024 · 19ced7d · 19ced7d
1 parent 5a6a29f
commit 19ced7d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/Nethermind/Nethermind.Runner/JsonRpc/Startup.cs b/src/Nethermind/Nethermind.Runner/JsonRpc/Startup.cs
@@ -215,7 +215,7 @@ await PushErrorResponse(StatusCodes.Status403Forbidden, ErrorCodes.InvalidReques
                                     {
                                         jsonSerializer.Serialize(resultWriter, result.Response);
                                     }
-
+                                    await resultWriter.CompleteAsync();
                                     if (stream is not null)
                                     {
                                         ctx.Response.ContentLength = resultWriter.WrittenCount;

diff --git a/src/Nethermind/Nethermind.Serialization.Json/StreamPipeWriter.cs b/src/Nethermind/Nethermind.Serialization.Json/StreamPipeWriter.cs
@@ -18,7 +18,8 @@ namespace Nethermind.Serialization.Json;
 
 public interface ICountingBufferWriter : IBufferWriter<byte>
 {
-    public long WrittenCount { get; }
+    long WrittenCount { get; }
+    ValueTask CompleteAsync(Exception? exception = null);
 }
 
 public sealed class CountingPipeWriter : ICountingBufferWriter
@@ -42,6 +43,12 @@ public void Advance(int count)
     public Memory<byte> GetMemory(int sizeHint = 0) => _writer.GetMemory(sizeHint);
 
     public Span<byte> GetSpan(int sizeHint = 0) => _writer.GetSpan(sizeHint);
+
+    public ValueTask CompleteAsync(Exception? exception = null)
+    {
+        return _writer.CompleteAsync();
+    }
+
 }
 
 public sealed class CountingStreamPipeWriter : PipeWriter, ICountingBufferWriter