Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(weapp): 修复微信 Map 组件在 Android 环境下且小程序基础库 v3.4.10+ 出现的属性配置异常 #16603

Merged
merged 6 commits into from
Sep 27, 2024

Conversation

koppthe
Copy link
Contributor

@koppthe koppthe commented Sep 26, 2024

这个 PR 做了什么? (简要描述所做更改)

  1. 优化 isNumber 判断逻辑;
  2. 修复微信 Map 组件 setting 属性的默认设置值问题;

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

1. 优化 isNumber 判断逻辑;
2. 修复微信 Map 组件 setting 属性的默认设置值问题;
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 58.51%. Comparing base (bcbd228) to head (89febb0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tests/__tests__/bundled/globby/index.js 53.33% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #16603   +/-   ##
=======================================
  Coverage   58.51%   58.51%           
=======================================
  Files         466      466           
  Lines       27109    27115    +6     
  Branches     5959     5956    -3     
=======================================
+ Hits        15862    15866    +4     
- Misses       9903     9925   +22     
+ Partials     1344     1324   -20     
Flag Coverage Δ
taro-cli 73.67% <ø> (ø)
taro-runtime 59.83% <ø> (ø)
taro-web 52.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tests/__tests__/bundled/globby/index.js 42.43% <53.33%> (+0.03%) ⬆️

... and 20 files with indirect coverage changes

Copy link
Contributor

@ZakaryCode ZakaryCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大佬牛逼

@koppthe koppthe merged commit 4bb4d2b into main Sep 27, 2024
38 checks passed
@koppthe koppthe deleted the fix/weapp-map branch September 27, 2024 03:28
@wanghui9309
Copy link

这个 PR 做了什么? (简要描述所做更改)

  1. 优化 isNumber 判断逻辑;
  2. 修复微信 Map 组件 setting 属性的默认设置值问题;

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

咨询一下,目前这个问题修复了之后,Taro历史版本是否是自己做兼容?

@koppthe
Copy link
Contributor Author

koppthe commented Sep 27, 2024

是的,旧版本需要手动添加 setting 属性

@wanghui9309
Copy link

是的,旧版本需要手动添加 setting 属性

了解,看上面这个问题被合并到4.0.7分支下,后续是不是Taro 4.0.7 及以后版本不需要做这类的容错

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants