Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strapdown.js to support custom squirts and copyrights using the <squirt> and <copyright> tags in <head>. #11

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ElnuDev
Copy link

@ElnuDev ElnuDev commented Jan 23, 2021

Fixes #10. Minified file needs to be updated.

My apologies if I've done something wrong, this is my first pull request on GitHub!

@Naereen
Copy link
Owner

Naereen commented Jan 23, 2021

Oh, that's an interesting trick!

Can you please show a screenshot of how it looks on one of your page, with/without both and tags?

I'll try it myself, then merge your pull-request, and update the minified files.

I would also like to note that if HTML purists see your custom and tags, they won't be happy about them, but I don't care.

@ElnuDev
Copy link
Author

ElnuDev commented Jan 23, 2021

Thanks for taking a look!

Here's my page with <squirt> and <copyright>:
Screenshot from 2021-01-23 11-25-30

Here's my page without <squirt> and <copyright>:
Screenshot from 2021-01-23 11-28-54

I'm not sure, perhaps it would be better just to have one tag (<subtitle>, perhaps?) that allows complete customizability and covers the whole section, instead of being forced to used <squirt> and <copyright>.

@Naereen
Copy link
Owner

Naereen commented Jan 25, 2021

I like your approach, as it allows to customize the location and content of the copyright notice.

I would also like to add an option, that works like the others currently supported by StrapDown.js :
see this page for more details : https://naereen.github.io/StrapDown.js/example5.html

I'll do it myself, probably adding nosquirt=y and nocopyright=y. Except if you have a better suggestion?
(I'll wait for a reply before merging this PR and adding my idea of these two tiny options)

@ElnuDev
Copy link
Author

ElnuDev commented Jan 25, 2021

That sounds like a good idea! It's certainly cleaner than only being able to have empty <squirt> and <copyright> tags, which is the only way to remove the squirt and copyright in the system I set up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a way to change the default banner text?
2 participants