Build: Add Sonar PR decoration #4
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to think about the coverage format. I think this will break ReportGenerator coverage report. Reportgenerator does support opencover I believe. Need to make sure local coverage tools still work. Also we may be able to remove the coverlet package in the main repo |
mikes-gh
reviewed
Sep 10, 2024
| @@ -86,12 +81,11 @@ jobs: | |||
| run: dotnet build -c Release --no-restore | |||
|
|
|||
| - name: Test | |||
| run: dotnet test -c Release --no-build --no-restore --blame-hang --blame-hang-timeout 60s /property:GenerateFullPaths=true /consoleloggerparameters:NoSummary /p:CollectCoverage=true /p:CoverletOutputFormat=cobertura /p:ExcludeByAttribute='ExcludeFromCodeCoverageAttribute' /p:ExcludeByAttribute='CompilerGeneratedAttribute' /p:ExcludeByFile='**/*.g.cs' /p:Include='[MudBlazor]*' /p:SkipAutoProps=true /p:CoverletOutput='./TestResults/' | |||
There was a problem hiding this comment.
Just wondering why you removed the include. Doesnt this now show code coverage outside the library
There was a problem hiding this comment.
Yeah I think this is required for the Source Generator and the Analyser. Both have tests but the coverage was not included.
There was a problem hiding this comment.
How is the coverage excluded from the other projects are they annotated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opencoverformat for SonarCloud.8.0.1due to this issue.Needs to be merged before MudBlazor/MudBlazor#9774.