Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow users to remove linea from networks list #27512

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Sep 30, 2024

Description

Users should be allowed to remove Linea from networks list

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-387

Manual testing steps

  1. Go to networks list, ensure that you can remove linea, even though it is a default network.

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Sep 30, 2024

@gambinish gambinish marked this pull request as ready for review September 30, 2024 21:57
@gambinish gambinish requested a review from a team as a code owner September 30, 2024 21:57
@metamaskbot
Copy link
Collaborator

Builds ready [8c9bf20]
Page Load Metrics (1848 ± 127 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28022661659517248
domContentLoaded145822561813260125
load146622661848264127
domInteractive248241199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -39 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants