fix: uninitialized constant Tap::TAP_DIRECTORY
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesch
reviewed
Aug 27, 2024
lib/toolchain.rb
Outdated
| @@ -1,6 +1,7 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| TAP_PATH = (Tap::TAP_DIRECTORY/"MaterializeInc"/"homebrew-crosstools").freeze | |||
| TAP_DIR = HOMEBREW_TAP_DIRECTORY || Tap::TAP_DIRECTORY | |||
There was a problem hiding this comment.
I don't think the || will work as you expect. HOMEBREW_TAP_DIRECTORY will just explode if it's not defined, right? I'd just use only HOMEBREW_TAP_DIRECTORY and let's just tell everyone to upgrade.
There was a problem hiding this comment.
No idea! Using just HOMEBREW_TAP_DIRECTORY and telling folks to upgrade works for me!
There was a problem hiding this comment.
Ahhh yeah looks like you're right, it just explodes, Playground
benesch
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
Tap::TAP_DIRECTORYwas replaced in favor ofHOMEBREW_TAP_DIRECTORYin Homebrew/brew#18010, now when trying to install a package from this tap I get the following error:I don't know Ruby very well but I think this change should work