Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adding support for subcollections and related subresources #80

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Commits on Apr 2, 2018

  1. Adding support for subcollections and related subresources

    - Dynamically driven by the "subcollections" exposed via OPTIONS /api/:collection
    - supports queries and actions
    
      Queries:
      miq.vms.find(166).tags.collect(&:name)
      miq.vms.find(166).tags.select(:categorization).collect(&:categorization)
    
      Subcollection Actions:
      miq.vms.find(166).tags.assign(:name => "/managed/location/ny")
      miq.vms.find(166).tags.assign([{:name => "/managed/location/chicago"}, {:name => "/managed/cc/001"}])
    
      Subcollection resource actions:
      miq.vms.find(166).tags.find(32).unassign
      miq.vms.find(166).tags.where(:name => "/managed/location/*").collect(&:unassign)
    
    Fixes: ManageIQ#31
    Fixes: ManageIQ#32
    abellotti committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    a21b621 View commit details
    Browse the repository at this point in the history
  2. Refactorying/Drying up

    - Moving action specific action methods for resources and subresources to seperate mixin.
    - Moving action specific action methods for collections and subcollections to seperate mixin.
    - Moving common queryable methods for collections and subcollections to a common QueryableMixin
    abellotti committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    944b385 View commit details
    Browse the repository at this point in the history
  3. Adding rspecs - options, collections and resources

    - Updated options response fixture to include subcollections
    - Added collection rspecs
    - Added resource rspecs
    abellotti committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    58456c7 View commit details
    Browse the repository at this point in the history
  4. Adding rspecs - subcollections

    - Add tests for subcollections
    abellotti committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    86572d3 View commit details
    Browse the repository at this point in the history
  5. Rspecs - Updated test to used action specific responses

    - Adding resource actions_vms.json
    - Adding subcollection actions_vm_tags.json
    abellotti committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    1e4c70e View commit details
    Browse the repository at this point in the history
  6. Adding rspecs - subresources

    - Adding tests for subresources
    abellotti committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    2ba97ed View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    52e3387 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a720dab View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4ee881d View commit details
    Browse the repository at this point in the history
  10. Common methods each and self.subclass for collections and subcollections

    moved to the common collection mixin
    abellotti committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    f2c4814 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2018

  1. Configuration menu
    Copy the full SHA
    640628c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0e28739 View commit details
    Browse the repository at this point in the history
  3. Removed duplicated code from collection.rb. Those methods were

    parameters_from_query_relation, filters_from_query_relation and order_parameters_from_query_relation
    which really live in the mixins/queryable_mixin.rb
    abellotti committed Apr 3, 2018
    Configuration menu
    Copy the full SHA
    b374164 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d9d6859 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2018

  1. Configuration menu
    Copy the full SHA
    a9cfa51 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b620767 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    64cccc6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0dc969d View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2018

  1. Made Subcollection a subclass of Collection and removed the

    need for the collection_action_mixin.rb
    abellotti committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    bcce855 View commit details
    Browse the repository at this point in the history