Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

288 http error #309

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

288 http error #309

wants to merge 7 commits into from

Conversation

joeywangzr
Copy link
Member

Description

Fixed bug where http error popup shows up if user selects https

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Note: make sure your files are formatted with rust-analyzer

the previous "error" warning had a top margin
the you may need to adjust your network warning was not fully stretched
@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for lodestone-dashboard ready!

Name Link
🔨 Latest commit bad1bd5
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-dashboard/deploys/64c1e9ebc3a5cc0008826c7f
😎 Deploy Preview https://deploy-preview-309--lodestone-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for lodestone-storybook ready!

Name Link
🔨 Latest commit bad1bd5
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-storybook/deploys/64c1e9eb74b9910007063975
😎 Deploy Preview https://deploy-preview-309--lodestone-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dashboard/src/pages/login/CoreConnect.tsx Outdated Show resolved Hide resolved
dashboard/src/pages/login/CoreConnect.tsx Outdated Show resolved Hide resolved
dashboard/src/pages/login/CoreConnect.tsx Outdated Show resolved Hide resolved
dashboard/src/pages/login/CoreConnect.tsx Outdated Show resolved Hide resolved
verify if nullable is correctly implemented
- renamed sethttpProtocol --> setHttpProtocol
- shortened if statement
- moved classname directly into warningalert
@CheatCod CheatCod requested a review from Ynng July 29, 2023 21:41
@@ -44,6 +45,7 @@ const CoreConnect = () => {
values: CoreConnectionInfo,
actions: FormikHelpers<CoreConnectionInfo>
) => {
setHttpProtocol(values.protocol == "http");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add a special case for localhost/127.0.0.1/etc, which does not need mixed content enabled

https://developer.mozilla.org/en-US/docs/Web/Security/Mixed_content#loading_locally_delivered_mixed-resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants