Fix setRange call to vtkDataArray for single component arrays #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadh4v
changed the title
|
Oh, I didn't realize you were looking into this from the react-vtk-js side. This was fixed in vtk.js proper: Kitware/vtk-js#2872 |
jadh4v
commented
Jul 26, 2023
For a vtkDataArray of single component, range is cached with index = 0 and not with index = numberOfComponents = 1
jadh4v
force-pushed
the
fix-DataArray-setRange
branch
from
23837fd
to
f2efe04
Compare
|
LGTM! |
|
🎉 This PR is included in version 2.0.0-beta.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix setRange call to vtkDataArray for single component arrays.
There may be cases (such as here) where an explicit call is made to
vtkDataArray::getRange(range, 0)with index === 0. This can trigger unexpected call to computeRange if setRange isn't called with index === 0 before.