Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: some UI #76

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

New: some UI #76

wants to merge 3 commits into from

Conversation

X-20A
Copy link

@X-20A X-20A commented Jun 17, 2024

#73
I wrote about the following UI, including the one I proposed in the issue

a. Clipboard copy function on results screen (a'. and simple notification function)
b.Keyboard shortcuts (for now, for the start of calculation)
c.One click on the text area for importing deck builder data will select all the data.

Each does not interfere with the other, so it is possible to incorporate them in parts.
What do you think?

_2024_06_17_22_30_11_572.mp4

@X-20A
Copy link
Author

X-20A commented Jun 18, 2024

I have edited some of the designs (see video)
I'd like to make sure the background doesn't scroll while the modal is displayed.
This is possible in ACSim, but it may be difficult if, for example, it depends on the structure of the component.
All these changes are completed in css.

_2024_06_18_20_28_41_656.mp4

fourinone41 added a commit that referenced this pull request Jun 29, 2024
…rea click selects all, modal no overscroll (#73) (#76)

sim: aaci 48 (provisional)
update data
@fourinone41
Copy link
Contributor

Thank you for these contributions. I have adapted the following based on your code:

  • a. Clipboard copy function on results screen (a'. and simple notification function)
  • c.One click on the text area for importing deck builder data will select all the data.
  • overscroll-behavior

Question:

retreat: 12.8%, S rate: 63.5%

I think it may be ambiguous without context of other stats (e.g. showing they sum to 100%), unclear if it means "X% retreat, AND Y% S-rank overall including retreats" (correct) or "X% retreat, THEN Y% S-rank only if you reach boss node" (wrong). Do you think it's still useful to include retreat rate in the copied text?

By the way, are you a JP speaker? I wonder would you be interested in translating other UI terms to JP? I was thinking to add i18n support, so let me know if you're interested.

@X-20A
Copy link
Author

X-20A commented Jun 29, 2024

I think it may be ambiguous without context of other stats (e.g. showing they sum to 100%), unclear if it means "X% retreat, AND Y% S-rank overall including retreats" (correct) or "X% retreat, THEN Y% S-rank only if you reach boss node" (wrong). Do you think it's still useful to include retreat rate in the copied text?

The copy button is on the "Avg Resource Per~" and away from the "Rank Per Battle".
I think it's hard to confuse the two.
The retreat rate is an important indicator for optimizing the composition and efficiency of laps, so I think it's better to include it.
Although confusion could be avoided if some kind of explanation is given to the text to be copied,
However, if the user has to edit the text manually, it may be a total waste of time.
I would prefer to be as concise as possible.

By the way, are you a JP speaker? I wonder would you be interested in translating other UI terms to JP? I was thinking to add i18n support, so let me know if you're interested.

Yes, I am a native Japanese speaker.
I have not written directly about i18n, but, well, I can probably work something out, and it will be meaningful for Japanese users.
How about starting a new issue?

@X-20A
Copy link
Author

X-20A commented Jun 29, 2024

What is the 'Special Attack Activation Rate'?

@X-20A
Copy link
Author

X-20A commented Jun 30, 2024

Does "Shelling Range Tie Randomness Weights" mean that there is a bias in the order of attack when there are multiple ships with the same range?

@X-20A
Copy link
Author

X-20A commented Jun 30, 2024

Does "Override Support Fleet Chance" mean the probability that the support fleet will not come?
And is the value fixed?

@fourinone41
Copy link
Contributor

My suggestion is to include all possible outcomes summing to 100%:
S rate: 63.5% (retreat: 12.8%, non-S: 23.7%)
Do you think this is better?

What is the 'Special Attack Activation Rate'?

These are the fixed values which the simulator uses to determine the chance of Special Attacks triggering. Since the actual formulas are not well understood, there is no automatic fleet-based calculation implemented, it uses only these fixed values.
If in the future I do implement automatic calculation, then these will work as "overrides", just like "Override Support Fleet Chance" below.

Does "Shelling Range Tie Randomness Weights" mean that there is a bias in the order of attack when there are multiple ships with the same range?

Yes. For example, it is the same behaviour described here: https://cc-jabberwock.hatenablog.com/entry/2023/01/28/230903

Does "Override Support Fleet Chance" mean the probability that the support fleet will not come?
And is the value fixed?

It means "the probability that the support fleet comes, which replaces the usual calculation". The purpose is to experiment with new 艦隊通信アンテナ effects, since we do not know the calculations yet. The values are fixed.

@fourinone41 fourinone41 mentioned this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants