Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new example from video stream and video4linux #14

Merged
merged 12 commits into from
Jul 24, 2018
Merged

Conversation

dehann
Copy link
Member

@dehann dehann commented Apr 3, 2018

No description provided.

@dehann dehann requested a review from Affie April 3, 2018 20:46
@codecov-io
Copy link

codecov-io commented Apr 3, 2018

Codecov Report

Merging #14 into master will increase coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   94.23%   95.37%   +1.13%     
==========================================
  Files           4        4              
  Lines         243      324      +81     
==========================================
+ Hits          229      309      +80     
- Misses         14       15       +1
Impacted Files Coverage Δ
src/helpers.jl 99.03% <0%> (+0.56%) ⬆️
src/wrapper.jl 55.17% <0%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75e8c58...1436b6c. Read the comment docs.

Copy link
Member

@Affie Affie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I use it in the same way, but didn't want to include it as an example as it uses an unregistered package (V4L.jl).
If you think its ok, you can go ahead and merge it.

@dehann
Copy link
Member Author

dehann commented Apr 5, 2018

I think there is a lot of new memory being created in the current conversion code. I'm guessing there is room for major speedups with Video4Linux if we use view, colorview, and normedview more extensively. We want @time or @btime to read very low levels of new memory consumption... I will commit what I have to v4l.

@Affie
Copy link
Member

Affie commented Apr 5, 2018

Thanks, I think you are correct that there is a lot of room for speedups and any help is much appreciated.
Just take note we found a memory leak in imshow JuliaImages/ImageView.jl#138.

@dehann
Copy link
Member Author

dehann commented Apr 19, 2018

Will certainly help with the speedups. I think it is okay to merge the first example. It would probably be better to move the second LCM message example elsewhere... Maybe directly to Caesar.jl since the LCM types are stored in CaesarLCMTypes.jl.

@dehann
Copy link
Member Author

dehann commented Apr 19, 2018

xref dehann/Caesar.jl#102

@Affie
Copy link
Member

Affie commented Jul 24, 2018

@dehann, I changed the imshow to avoid the memory leak. It should perform way better now.

@dehann
Copy link
Member Author

dehann commented Jul 24, 2018

Hi, Thanks!

@dehann
Copy link
Member Author

dehann commented Jul 24, 2018

can merge if ready.

@dehann
Copy link
Member Author

dehann commented Jul 24, 2018

cc @GearsAD, for the less leaky memory imshow canvas update.

@dehann dehann added this to the v0.0.2 milestone Jul 24, 2018
@Affie Affie merged commit 780c8ee into master Jul 24, 2018
@Affie Affie deleted the examples/fromvideo branch August 23, 2018 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants