Cache output of restrict to reduce redraw time
#313
Conversation
There was a problem hiding this comment.
This looks like a good idea. However, it might be better to just implement a proper Pyramid type (see JuliaImages/ImageBase.jl#39) and suggest that users employ that for better performance.
| function copy_with_restrict!(cnvs, img::AbstractMatrix) | ||
| imgsz = size(img) | ||
| # cache of the image plus downscaled versions | ||
| ImagePyramid(img::AbstractMatrix) = Any[img] |
There was a problem hiding this comment.
Since this is a function, not a type, it should be lowercase.
ImageView supports n-dimensional images, so perhaps this should be generalized beyond AbstractMatrix? Or does this only happen after slice-selection? If a user is browsing a large 3d array, would the entire pyramid be recomputed each time one changes slice planes?
| pyr | ||
| end | ||
|
|
||
| function get_image(p, i) |
There was a problem hiding this comment.
| function get_image(p, i) | |
| function get_restricted_image!(p, i) |
Can we use more descriptive variable names than p and i?
|
Ah, I didn't see that a pyramid type was in the works. |
|
It's been something we could have added since |
Reduces latency a bit when zooming around large images, partially addressing #300.