Operational Learning Summary Generation #2227

susilnem · 2024-07-25T10:35:23Z

Addresses

Changes

Need to install poetry
Run command python manage.py create_dummy_opslearningsummary to generate mock

Checklist

Things that should succeed before merging.

Updated/ran unit tests
Updated CHANGELOG.md

Release

If there is a version update, make sure to tag the repository with the latest version.

thenav56

Round 1

thenav56 · 2024-08-15T04:52:19Z

per/models.py

+
+class OpsLearningPromptResponseCache(models.Model):
+    class PromptType(models.IntegerChoices):
+        PRIMARY = 0, _("primary")


Let's try to avoid using 0, as it can have issue if we use if/else with it.

Let's do the same for others as well

thenav56 · 2024-08-15T04:55:37Z

per/models.py

+    insights1_confidence_level = models.CharField(verbose_name=_("insights 1 confidence level"), null=True, blank=True)
+    insights2_confidence_level = models.CharField(verbose_name=_("insights 2 confidence level"), null=True, blank=True)
+    insights3_confidence_level = models.CharField(verbose_name=_("insights 3 confidence level"), null=True, blank=True)


Can we add max_length here as well?

thenav56 · 2024-08-15T04:58:46Z

deployments/factories/project.py

@@ -22,7 +22,7 @@ class SectorTagFactory(factory.django.DjangoModelFactory):
    class Meta:
        model = models.SectorTag

-    title = fuzzy.FuzzyText(length=50, prefix="sect-tag-")
+    title = factory.Faker("sentence", nb_words=5)


Any reason why we are changing this?

NOTE: We used "sect-tag-" to make it readable among error diffs and snapshot. Also changing this will require changes on lots of existing snapshot

thenav56 · 2024-08-15T05:01:53Z

per/drf_views.py

@@ -701,6 +717,21 @@ class Meta:
            "appeal_code__region": ("exact", "in"),
        }

+    def get_cache_response(self, queryset, name, value):
+        if ops_learning_cache_response := OpsLearningCacheResponse.objects.filter(id=value).first():


Let's also add additional check

Suggested change

if ops_learning_cache_response := OpsLearningCacheResponse.objects.filter(id=value).first():

if value and (ops_learning_cache_response := OpsLearningCacheResponse.objects.filter(id=value).first()):

thenav56 · 2024-08-15T05:03:59Z

per/serializers.py

@@ -1046,6 +1049,29 @@ class Meta:
        exclude = ("learning", "type", "organization", "sector", "per_component")


+class AppealDetailSerializer(serializers.ModelSerializer):
+    atype = serializers.SerializerMethodField()


Maybe use this instead? SerializerMethodField doesn't provide proper schema

Suggested change

atype = serializers.SerializerMethodField()

atype_display = serializers.CharField(source='get_atype_display', read_only=True)

thenav56 · 2024-08-15T05:04:20Z

per/serializers.py

+        ]
+
+    def get_extract_count(self, obj) -> int:
+        return obj.used_ops_learning.count()


thenav56 · 2024-08-15T05:15:38Z

per/ops_learning_summary.py

+    client = AzureOpenAI(
+        azure_endpoint=settings.AZURE_OPENAI_ENDPOINT, api_key=settings.AZURE_OPENAI_KEY, api_version="2023-05-15"
+    )


Use cached_property for this

Add a TODO: to create a separate object for integration with Open AI for common use cases

thenav56 · 2024-08-15T05:18:39Z

per/task.py

+        logger.error(e)
+        raise e


Suggested change

logger.error(e)

raise e

# TODO: Add extra context for which ops learning cache response failed

logger.error("Ops learning process failed", exc_info=True)

return False

return True

thenav56 · 2024-08-15T05:19:38Z

per/task.py

+@shared_task
+def generate_summary(ops_learning_summary_id: int, filter_data: dict):
+    try:
+        ops_learning_summary_instance = OpsLearningCacheResponse.objects.filter(id=ops_learning_summary_id).first()


move this outside try

Suggested change

ops_learning_summary_instance = OpsLearningCacheResponse.objects.filter(id=ops_learning_summary_id).first()

ops_learning_summary_instance = OpsLearningCacheResponse.objects.filter(id=ops_learning_summary_id).first()

if ops_learning_summary_instance is None:

# TODO: Add extra context for which ops learning cache response failed

logger.error("Missing Ops learning cache response triggered")

return False

Code refactor of Prioritizing opslearning

Update primary instruction and Add New prompt instructions

Changes on mocking and response Add splitting confidence level value

Change latest prompt with used excerpts Add OpenAiChat class for AzureOpenAI Handle Empty df for Ops and recursive function for summary

susilnem force-pushed the feature/ops-learning-summary branch 7 times, most recently from b3019de to 5c0c71f Compare August 5, 2024 10:43

susilnem force-pushed the feature/ops-learning-summary branch 7 times, most recently from 77a1791 to 33d0ef5 Compare August 15, 2024 04:57

thenav56 requested changes Aug 15, 2024

View reviewed changes

susilnem force-pushed the feature/ops-learning-summary branch 15 times, most recently from 33e896f to b12217f Compare August 20, 2024 11:22

susilnem force-pushed the feature/ops-learning-summary branch 6 times, most recently from fda24ea to adb4a95 Compare September 5, 2024 04:33

susilnem force-pushed the feature/ops-learning-summary branch from adb4a95 to 5193556 Compare September 10, 2024 06:43

susilnem added 8 commits September 10, 2024 13:44

Add models and api for ops learning summary

aca6981

Add mock response and factories

bd3fbf6

Add priotization code and refactor api

79f933d

Add priotize component in opslearning

ebc41ed

Code refactor of Prioritizing opslearning

Add Prompt generation logic

9976fde

Add Generating summary section

6cd9892

Update primary instruction and Add New prompt instructions

Add new model for prompt caching and saving to db

4789d75

Changes on mocking and response Add splitting confidence level value

Caching implementation and add changes on parsing

8a3ece5

susilnem force-pushed the feature/ops-learning-summary branch from 5193556 to e41116b Compare September 10, 2024 08:00

Add new changes and Apis for extracts

c8b2a3b

Change latest prompt with used excerpts Add OpenAiChat class for AzureOpenAI Handle Empty df for Ops and recursive function for summary

susilnem force-pushed the feature/ops-learning-summary branch 9 times, most recently from 3a3bc3c to f5f14b2 Compare September 16, 2024 11:03

Add Redis lock implementation and Excel export

f5f14b2

This was referenced Sep 16, 2024

Operational Learning excerpts export IFRCGo/go-web-app#1369

Open

Multi select filters in Operational Learning IFRCGo/go-web-app#1387

Open

szabozoltan69 force-pushed the develop branch from c512fea to cc11ba1 Compare September 22, 2024 17:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Operational Learning Summary Generation #2227

Operational Learning Summary Generation #2227

susilnem commented Jul 25, 2024 •

edited

Loading

thenav56 left a comment

thenav56 Aug 15, 2024

thenav56 Aug 15, 2024

thenav56 Aug 15, 2024

thenav56 Aug 15, 2024

thenav56 Aug 15, 2024

thenav56 Aug 15, 2024

thenav56 Aug 15, 2024

thenav56 Aug 15, 2024

thenav56 Aug 15, 2024

	if ops_learning_cache_response := OpsLearningCacheResponse.objects.filter(id=value).first():
	if value and (ops_learning_cache_response := OpsLearningCacheResponse.objects.filter(id=value).first()):

	atype = serializers.SerializerMethodField()
	atype_display = serializers.CharField(source='get_atype_display', read_only=True)

-        logger.error(e)
-        raise e
+        # TODO: Add extra context for which ops learning cache response failed
+        logger.error("Ops learning process failed", exc_info=True)
+        return False
+   return True

Operational Learning Summary Generation #2227

Are you sure you want to change the base?

Operational Learning Summary Generation #2227

Conversation

susilnem commented Jul 25, 2024 • edited Loading

Changes

Checklist

Release

thenav56 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

susilnem commented Jul 25, 2024 •

edited

Loading