Run migration once; wait for migrations to run before starting api #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunu
changed the title
|
Can I try a merge? |
|
@szabozoltan69 this can still potentially make the api unavailable if things don't go as planned. We can try deploying together in ~ 1 hour with @batpad if that works for you? Also, looks like the the web-rewrite branch history just changed and we have a bunch of additional commits in the PR now. I'll rebase before we merge. |
|
(I think we should wait the go-rewrite cutover, and let's play with this afterwards. So let's postpone the merge until Thursday.) |
- run migration in a Job to ensure only one instance of migrations is run regardless of the number of api replicas - Use an init container to wait for migrations to finish running successfully before starting the api
selector is autogenerated by k8s based on the labels
sunu
force-pushed
the
feat/migration-job-2
branch
from
2bd483b
to
e4d25d1
Compare
szabozoltan69
force-pushed
the
develop
branch
4 times, most recently
from
17d0645
to
a8b22d7
Compare
szabozoltan69
force-pushed
the
develop
branch
from
c512fea
to
cc11ba1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1926
Continuation of #1932