install.sh: use printf to print post-install instructions
#881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Fish shell, parentheses are for command substitution, so the parenthesised subshell used for `echo` grouping does not work there. Instead let's use `printf` to print the post-install instructions; it's more portable. Fixes Homebrew#880.
carlocab
approved these changes
Sep 25, 2024
carlocab
reviewed
Sep 25, 2024
MikeMcQuaid
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Seems fine, thanks @ZhongRuoyu. Ideally we'd make this Fish-specific but can be in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Fish shell, parentheses are for command substitution, so the parenthesised subshell used for
echogrouping does not work there. Instead let's useprintfto print the post-install instructions; it's more portable.Fixes #880.