Use --concurrency with brew fetch
#1244
Open
+15
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should hopefully make CI just a little bit faster. It'll help us kick the tires on `--concurrency`.
carlocab
force-pushed
the
concurrent-fetch
branch
from
4c5c2ea
to
a4cea91
Compare
SMillerDev
approved these changes
Sep 29, 2024
ZhongRuoyu
approved these changes
Sep 29, 2024
| @@ -31,7 +31,9 @@ def fetch_bottles!(formula_name, args:) | |||
|
|
|||
| tags.each do |tag| | |||
| cleanup_during!(args:) | |||
| test "brew", "fetch", "--retry", "--formulae", "--bottle-tag=#{tag}", formula_name | |||
| test "brew", "fetch", "--retry", "--formulae", "--bottle-tag=#{tag}", | |||
| "--concurrency", Homebrew::EnvConfig.make_jobs, | |||
There was a problem hiding this comment.
What is Homebrew::EnvConfig.make_jobs in CI usually?
There was a problem hiding this comment.
Same as default -- number of cores. So somewhere between 2-6.
MikeMcQuaid
requested changes
Sep 30, 2024
There was a problem hiding this comment.
Hold off on this. Would like to see some more of Homebrew/brew#18278 (comment) done first, at least:
we should limit the hosts we'll download in parallel from to an allowlist so we don't e.g. try to download the 10 files at once from a poor personal web server when building from source
For now: starting with just GitHub and GitHub Packages makes sense to me.
To be explicit on what this means: it's ok to have 1 thread download from e.g. randomwebserver.com but not >1 at once unless it's e.g. GitHub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully make CI just a little bit faster. It'll help us
kick the tires on
--concurrency.