Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inchi 1.07.1 (new formula); open-babel rdkit: use inchi #192312

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

inchi 1.07.1 (new formula); open-babel rdkit: use inchi #192312

wants to merge 3 commits into from
+134 −5

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Sep 29, 2024 •
edited
Loading

Audit will fail due to patch and notability will also fail. Copy of failure from CI before CI-skip-new-formulae Pass --skip-new to brew test-bot. 

==> FAILED
Full audit --formula inchi --online --new output
  inchi
    * GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)
    * Formulae should not require patches to build. Patches should be submitted and accepted upstream first.
  Error: 2 problems in 1 formula detected.

Build system isn't the greatest. There is an upstream PR for CMake, but it lacks install targets so won't help there.

Mainly want to avoid building this inside 2 formulae.

Repology Ref: https://repology.org/project/inchi/versions

@cho-m cho-m added new formula PR adds a new formula to Homebrew/homebrew-core audit failure CI fails while auditing the software notability Project is not notable enough for inclusion CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Sep 29, 2024
@cho-m cho-m changed the title inchi 1.07.1 (new formula) inchi 1.07.1 (new formula); open-babel rdkit: use inchi Sep 29, 2024
carlocab
carlocab approved these changes Sep 29, 2024
View reviewed changes
Formula/i/inchi.rb Show resolved Hide resolved
@cho-m cho-m added the CI-skip-new-formulae Pass --skip-new to brew test-bot. label Sep 29, 2024
@cho-m cho-m marked this pull request as ready for review September 29, 2024 21:08
@cho-m cho-m removed the audit failure CI fails while auditing the software label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-new-formulae Pass --skip-new to brew test-bot. new formula PR adds a new formula to Homebrew/homebrew-core notability Project is not notable enough for inclusion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cho-m @chenrui333 @carlocab