Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crossplane 1.17.1 (new formula) #192300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

crossplane 1.17.1 (new formula) #192300

wants to merge 1 commit into from
+51 −0

Conversation

Moulick
Copy link
Contributor

@Moulick Moulick commented Sep 29, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

crossplane/crossplane#4899

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Sep 29, 2024
@Moulick Moulick changed the title Crossplane 1.17.0 Crossplane 1.17.0 (new formula) Sep 29, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 29, 2024
@Moulick Moulick marked this pull request as ready for review September 29, 2024 17:48
@Moulick Moulick marked this pull request as draft September 29, 2024 17:48
@Moulick Moulick changed the title Crossplane 1.17.0 (new formula) Crossplane 1.17.1 (new formula) Sep 29, 2024
@Moulick Moulick mentioned this pull request Sep 29, 2024
Open
@Moulick Moulick marked this pull request as ready for review September 29, 2024 18:00
Moulick
Moulick commented Sep 29, 2024
View reviewed changes
Formula/c/crossplane.rb Outdated Show resolved Hide resolved
chenrui333
chenrui333 reviewed Sep 29, 2024
View reviewed changes
Formula/c/crossplane.rb Outdated
depends_on "go" => :build

def install
system "go", "build", *std_go_args(ldflags: "-s -w -X=github.com/crossplane/crossplane/internal/version.version=v#{version}", output: bin/"crossplane"), "./cmd/crank"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why just build crank, but not crossplane as well?

Copy link
Contributor Author

@Moulick Moulick Sep 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand what's the use of crossplane binary for normal users. Following https://docs.crossplane.io/latest/cli/ the shell script referenced installs only the crank binary

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crank is the crossplane cli, crossplane is the actual crossplane binary, so in this context only crank makes sense indeed.

Copy link
Contributor Author

@Moulick Moulick Sep 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the crossplane binary runs in an init container to install some crossplane CRDs to a cluster where someone is installing Crossplane via Helm. It does not seems to be intended for running on local machines.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both as init container and main container. I confirm it's not meant to be run locally.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good then, just checking 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(related, would it make more sense to have the formula as crank, rather than crossplane then?)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crank is just an internal name, the cli should be called crossplane, so crossplane is correct 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So brew install crossplane will mean that there is no crossplane binary, just a crank one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brew install crossplane will install the crank binary as crossplane.

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 29, 2024
Moulick
Moulick commented Sep 29, 2024
View reviewed changes
Formula/c/crossplane.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 29, 2024
@Moulick Moulick force-pushed the crossplane-cli branch 2 times, most recently from b1d397b to 2df5389 Compare September 29, 2024 20:02
chenrui333
chenrui333 reviewed Sep 30, 2024
View reviewed changes
Formula/c/crossplane.rb Outdated Show resolved Hide resolved
@chenrui333 chenrui333 changed the title Crossplane 1.17.1 (new formula) crossplane 1.17.1 (new formula) Sep 30, 2024
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 30, 2024
chenrui333
chenrui333 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to squash the commits

@Moulick
crossplane 1.17.1 (new formula)
ac09bc9 
Signed-off-by: Moulick Aggarwal <[email protected]>
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 30, 2024
@Moulick
Copy link
Contributor Author

Moulick commented Sep 30, 2024

need to squash the commits

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SMillerDev SMillerDev SMillerDev left review comments

@phisco phisco phisco left review comments

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Moulick @SMillerDev @chenrui333 @phisco