Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc@5: fix MacOS usage (again) #191708

Merged
merged 2 commits into from
Sep 24, 2024
Merged

gcc@5: fix MacOS usage (again) #191708

merged 2 commits into from
Sep 24, 2024

Conversation

MikeMcQuaid
Copy link
Member

Follow-up second attempt of #191703
Needed for Homebrew/brew#18388

This looks a bit weird but it's the only places we're using MacOS::Xcode.version in a on_macos block like this.

@MikeMcQuaid MikeMcQuaid added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Sep 24, 2024
@MikeMcQuaid MikeMcQuaid requested review from carlocab and a team September 24, 2024 10:43
@github-actions github-actions bot added legacy Relates to a versioned @ formula formula disabled Formula disabled long build Set a long timeout for formula testing labels Sep 24, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 24, 2024
Merged via the queue into master with commit da47540 Sep 24, 2024
17 checks passed
@BrewTestBot BrewTestBot deleted the gcc_macos_usage_again branch September 24, 2024 10:51
@MikeMcQuaid
Copy link
Member Author

Thanks again @carlocab!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula disabled Formula disabled legacy Relates to a versioned @ formula long build Set a long timeout for formula testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikeMcQuaid @carlocab @BrewTestBot