Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove url do blocks #186501

Merged
merged 8 commits into from
Sep 25, 2024
Merged

Remove url do blocks #186501

merged 8 commits into from
Sep 25, 2024

Commits on Sep 25, 2024

  1. dolphin@dev: replace url do with versioned URL

    @Rylan12 @samford
    Rylan12 authored and samford committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8565c7c View commit details
    Browse the repository at this point in the history

  2. keepassxc@snapshot: replace url do with versioned URL

    @Rylan12 @samford
    Rylan12 authored and samford committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2edbb2e View commit details
    Browse the repository at this point in the history

  3. transmission@nightly: replace url do with versioned URL

    @Rylan12 @samford
    Rylan12 authored and samford committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7e9b262 View commit details
    Browse the repository at this point in the history

  4. vlc@nightly: replace url do with versioned URL

    @Rylan12 @samford
    Rylan12 authored and samford committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    523c69a View commit details
    Browse the repository at this point in the history

  5. dolphin@dev: update version, livecheck 

    The directories that precede the dmg file are different for each
build, so we also need to capture those and store them in the cask
`version`.
    @samford
    samford committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d2be1fb View commit details
    Browse the repository at this point in the history

  6. keepassxc@snapshot: update version, livecheck 

    All of the recent snapshot builds of `keepassxc` use a 2.8.0 version
in the filename. If we use the dmg file in the `/latest/` directory
and the version doesn't change between builds, then we will get a
checksum mismatch when the build is updated. Instead, we have to use
a fully-versioned URL that uses a build directory instead, as this
will remain static between builds.

Similarly, `/latest/` is an actual directory and not just a url that
redirects to the latest build, so checking the dmg file in that
directory won't give us the full URL with the build number in it.
With this setup, we have to find the newest build directory number
on the main snapshots page, then check the directory listing page
for that build directory to find the version in the dmg file name.
    @samford
    samford committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2ae49cf View commit details
    Browse the repository at this point in the history

  7. transmission@nightly: update version, livecheck 

    File names for nightly `transmission` releases only include a hash
but we also need the build number to be able to use a fully-versioned
URL. Using a `lastSuccessfulBuild` dmg URL would result in a 404 (Not
Found) response when the next build occurs, as the expected file
won't be available anymore. With that in mind, we need to use a
build-specific dmg URL.

This updates the cask to include the build number in the `version`
and to capture that information in the `livecheck` block regex.
Unfortunately the dmg URL on the `lastSuccessfulBuild` page doesn't
use a build number but we can identify the build number from other
areas of the page.
    @samford
    samford committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1275931 View commit details
    Browse the repository at this point in the history

  8. vlc@nightly: update version, livecheck 

    The file name version has remained consistent from the start of this
year (at least) but we should capture it in the `livecheck` regex
and include it in the cask `version`, so we can easily version bump
the cask if/when the version changes in the future.

Besides that, this reworks the `livecheck` block's `strategy` block
to better align with existing standards/patterns.
    @samford
    samford committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    dbd43d4 View commit details
    Browse the repository at this point in the history