Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/linux/ld: handle nonexistent ld.so.conf more gracefully #18459

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes #18458

@Bo98
Copy link
Member

Bo98 commented Sep 29, 2024

This might make sense when bootstrapping glibc so agree with this change for that.

As a fix for #18458 though: are we sure we're getting the system directories correctly? Otherwise it'll flag everything as broken linkage.

@carlocab
Copy link
Member Author

Added some defaults based on the output of OS::Linux::Ld.library_paths in a codespace. Also included the location of ld.so.conf as reported at #18458.

@carlocab carlocab requested a review from Bo98 September 30, 2024 13:22
@carlocab
Copy link
Member Author

Reverted to original changes per discussion on Zoom.

@carlocab carlocab merged commit cdc228a into master Sep 30, 2024
27 checks passed
@carlocab carlocab deleted the missing-ld.so.conf branch September 30, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants