livecheck/strategy/extract_plist: fix extract_plist url
#18438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -102,9 +102,16 @@ def self.find_versions(cask:, url: nil, regex: nil, **_unused, &block) | |||
|
|
|||
| unversioned_cask_checker = if url.present? && url != cask.url.to_s | |||
| # Create a copy of the `cask` that uses the `livecheck` block URL | |||
| cask_copy = Cask::CaskLoader.load(cask.sourcefile_path) | |||
| cask_copy.allow_reassignment = true | |||
| cask_copy.url { url } | |||
There was a problem hiding this comment.
Can you not just do cask_copy.url url?
There was a problem hiding this comment.
I tried that first.
Error: google-earth-pro: wrong number of arguments (given 1, expected 0)
/opt/homebrew/Library/Homebrew/cask/cask.rb:121:in `block (2 levels) in <class:Cask>'
/opt/homebrew/Library/Homebrew/livecheck/strategy/extract_plist.rb:107:in `find_versions'
There was a problem hiding this comment.
I think that's because we define the DSL methods without forwarding arguments here:
brew/Library/Homebrew/cask/cask.rb
Line 121 in 3b26dd8
bevanjkay
force-pushed
the
extract_plist_url_fix
branch
from
1df973a
to
63a7847
Compare
MikeMcQuaid
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?When a custom
urlis passed to the ExtractPlist livecheck strategy, we were creating a copy of the cask and replacing theurl. This was being parsed as a block, which was causing a deprecation error now thaturl doblocks are deprecated.This PR instead creates a minimal copy of the cask and passes it to CaskLoader as content instead of copying the entire cask.