Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula: add size information to JSON API #18403

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Sep 24, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Will be using this PR to essentially jot some ideas down. Needs #18172 beforehand. May end up combining parts of this into other PR.

  • General idea right now is to let JSON code path pick up already fetched manifests and populate size information if they exist.
  • Re-use brew fetch so we can make use of --concurrency with new --only-manifests to pull quickly pull down all formulae manifests.
  • Need to find where to inject the information to bypass manifest fetch when loading API data

@cho-m cho-m mentioned this pull request Sep 24, 2024
7 tasks
@MikeMcQuaid
Copy link
Member

Needs #18172 beforehand.

For cases like this:

This means the diff/CI will be correct and it'll fall through to targeting master when that PR is merged.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Good to go when ready.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually: not seeing where this is added to JSON API yet but assuming that's coming later.

As we discussed before I think it makes sense to:

  • have multiple sizes across the variations when they are available
  • consider having a top-level size key that is the only size if only one is available and something like the mean size if multiple are?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants