workflows/tests: use the container and macos-14 for some jobs

[ZhongRuoyu]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

The containers have homebrew/core tapped so we don't need to wait forever for the core repo to be cloned.

The tap syntax job requires all official taps. Unlike the Ubuntu images ¹, macos-14 has both core and cask tapped ² so setting up Homebrew should be faster there. We don't use the containers because the cask tap is not available by default.

Footnotes

1. https://github.com/actions/runner-images/blob/ubuntu24/20240922.1/images/ubuntu/scripts/build/install-homebrew.sh ↩

2. https://github.com/actions/runner-images/blob/macos-14/20240923.101/images/macos/scripts/build/install-homebrew.sh#L23-L24 ↩

[MikeMcQuaid]

Nice work @ZhongRuoyu! Makes sense to me. Have suggested tweaks to defaults for a few containers where we don't explicitly mention the version to avoid needing updates in future and potentially catch issues quicker on the default container.

[ZhongRuoyu]

We don't have homebrew/brew:master though, only homebrew/ubuntu22.04 for master:

brew/.github/workflows/docker.yml

Lines 78 to 85 in cee2287

	elif [[ "${GITHUB_EVENT_NAME}" == "push" &&
	"${GITHUB_REF}" == "refs/heads/master" &&
	"${{ matrix.version }}" == "22.04" ]]; then
	tags+=(
	"ghcr.io/homebrew/ubuntu${{ matrix.version }}:master"
	"homebrew/ubuntu${{matrix.version}}:master"
	)
	fi

Perhaps we can publish homebrew/brew:master too?

[MikeMcQuaid]

We don't have homebrew/brew:master though, only homebrew/ubuntu22.04 for master:

Ooo, my bad.

Perhaps we can publish homebrew/brew:master too?

Yeh, I think it'd be ideal to have a master Docker build of some sort that can be tracked without caring about the underlying Ubuntu version?

That doesn't need to block this PR, though!

[ZhongRuoyu]

Yeh, I think it'd be ideal to have a master Docker build of some sort that can be tracked without caring about the underlying Ubuntu version?

Agreed. Here we go: #18396

[ZhongRuoyu]

The codecov action failed because it's trying to download a binary to the action's directory:

Error: Codecov: Failed to write uploader binary: EACCES: permission denied, open '/__w/_actions/codecov/codecov-action/e28ff129e5465c2c0dcc6f003fc735cb6ae0c673/dist/codecov'

Is it possible/desirable to set up ACL for the actions directory in setup-homebrew, @Bo98? Though there doesn't seem to be an environment variable for that.

[Bo98]

Maybe - I'll need to investigate to see.

Quick initial question though: do we get any speedup from using the containers for RSpec tests? Homebrew/core shouldn't be required there.

[ZhongRuoyu]

do we get any speedup from using the containers for RSpec tests?

The speedup is only in not having to tap homebrew/core. That aside, the speed is roughly the same (see before and after).

Homebrew/core shouldn't be required there.

In that case perhaps we could just set core: false for these tests.

[ZhongRuoyu]

Homebrew/core shouldn't be required there.

Is #15634 (comment) no longer the case?

[Bo98]

Ah there's two remaining tests that still use Homebrew/core: https://github.com/search?q=repo%3AHomebrew%2Fbrew%20needs_homebrew_core&type=code.

Though maybe the macOS coverage is good enough for them. With proper stubbing to remove the need of Homebrew/core for brew --prefix: the answer is almost certainly yes.

[MikeMcQuaid]

Thanks @ZhongRuoyu!