-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows/docker: use docker/build-push-action
to build images
#18175
Conversation
|
Done! Do we want/need to use https://github.com/docker/setup-buildx-action or https://github.com/docker/login-action? |
96cfd5e
to
48ac3db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far, thanks @ZhongRuoyu!
|
We probably need Docker Buildx for this: https://github.com/docker/setup-buildx-action. @MikeMcQuaid will you whitelist this too? |
Done! |
dfb6c70
to
86312cd
Compare
This allows us to use Docker's build cache across workflow runs. Co-authored-by: Carlo Cabrera <[email protected]>
5d67b95
to
d1173f4
Compare
Co-authored-by: Carlo Cabrera <[email protected]>
d1173f4
to
73b8950
Compare
Thanks @ZhongRuoyu! |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This allows us to use Docker's build cache across workflow runs.
Follow-up to #18168 (comment).