Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diagnostic: fix XDG_DATA_DIRS check #17947

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

gromgit
Copy link
Member

@gromgit gromgit commented Aug 3, 2024

  1. Pass XDG_DATA_DIRS through so that it can be checked.
  2. Promote the check to cross-platform status, as an incorrect XDG_DATA_DIRS also affects macOS formulae.

Complements #17932, addresses Homebrew/homebrew-core#179217 (comment).

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

bin/brew Outdated Show resolved Hide resolved
Library/Homebrew/diagnostic.rb Outdated Show resolved Hide resolved
Pass `XDG_DATA_DIRS` through `bin/brew` so that it can be checked.
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed previously: I want to keep this as Linux-only. Have amended the commit to do so.

Thanks for the PR @gromgit, thanks! I'll address other comments 🔜.

@MikeMcQuaid MikeMcQuaid merged commit a8e6262 into Homebrew:master Aug 5, 2024
24 checks passed
@gromgit gromgit deleted the diagnostic/xdg-data-dirs branch September 1, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants