Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Enable HOMEBREW_AUTOREMOVE by autoremove_default"" #17369

Merged
merged 1 commit into from
May 26, 2024

Conversation

MikeMcQuaid
Copy link
Member

Reverts #17364

Reverting this until we have more discussion during the week.

@MikeMcQuaid MikeMcQuaid requested review from carlocab, p-linnane and a team May 26, 2024 14:45
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the quick merge on the previous PR 🙇

@MikeMcQuaid MikeMcQuaid merged commit cb168df into master May 26, 2024
26 checks passed
@MikeMcQuaid MikeMcQuaid deleted the revert-17364-revert-autoremove branch May 26, 2024 14:52
@MikeMcQuaid
Copy link
Member Author

@p-linnane Thanks for quick approval on this one! No problem, it happens and it's often the right thing to do, I just think in this case when it's a big change in behaviour that we've announced publicly that the burden to reverting is/should be much higher than we've seen.

@github-actions github-actions bot added the outdated PR was locked due to age label Jun 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants