Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump plist from 3.7.0 to 3.7.1 in /Library/Homebrew #16402

Merged
merged 4 commits into from
Dec 28, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 26, 2023

Bumps plist from 3.7.0 to 3.7.1.

Release notes

Sourced from plist's releases.

3.7.1

Bug fixes

  • Remove runtime dependency on base64 gem to fix Ruby 3.3 warning (patsplat/plist#63)

Housekeeping

Full Changelog: patsplat/plist@v3.7.0...v3.7.1

Changelog

Sourced from plist's changelog.

=== 3.7.1 (2023-12-26)

patsplat/plist@v3.7.0...v3.7.1

Bug fixes:

  • Remove runtime dependency on base64 gem to fix Ruby 3.3 warning (patsplat/plist#63)

Housekeeping:

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [plist](https://github.com/patsplat/plist) from 3.7.0 to 3.7.1.
- [Release notes](https://github.com/patsplat/plist/releases)
- [Changelog](https://github.com/patsplat/plist/blob/master/CHANGELOG.rdoc)
- [Commits](patsplat/plist@v3.7.0...v3.7.1)

---
updated-dependencies:
- dependency-name: plist
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Bumping Gemfile dependencies ruby Pull requests that update Ruby code labels Dec 26, 2023
@apainintheneck
Copy link
Contributor

This new version of the plist gem removes the dependency on the base64 gem which will be removed from the standard library in Ruby 3.4. We can either include it explicitly or just roll our own since it's apparently a pretty thin wrapper around String#pack and String#unpack. We use the base64 gem when parsing the JSON web signature when verifying the API JSON.

@apainintheneck
Copy link
Contributor

Or since we're still on Ruby 3.1 we could just require it and decide on whether to keep it later on. It's still a part of the standard library right now; it's just no longer included indirectly.

This was required previously by the `plist` gem and we were requiring
it indirectly. It got removed in v1.7.1 of that gem because it will
no longer be included in the standard library as of Ruby 3.4.

Since we're not currently running on Ruby 3.3 and 3.4 is not out yet,
we can punt on this for now but we'll need to figure out a better
alternative before upgrading to Ruby 3.4.

Related:
- patsplat/plist#63
@Bo98
Copy link
Member

Bo98 commented Dec 28, 2023

We can either include it explicitly or just roll our own since it's apparently a pretty thin wrapper around String#pack and String#unpack. We use the base64 gem when parsing the JSON web signature when verifying the API JSON.

URL safe variant needs an extra swap of a couple characters but otherwise yes it's fairly lightweight. Fine to just require for now but yeah we'd probably want to think about something for Ruby 3.3 (since it'll start warning there) rather than 3.4.

@MikeMcQuaid MikeMcQuaid merged commit 67217f6 into master Dec 28, 2023
26 checks passed
@MikeMcQuaid MikeMcQuaid deleted the dependabot/bundler/Library/Homebrew/plist-3.7.1 branch December 28, 2023 08:16
@MikeMcQuaid
Copy link
Member

Thanks @Bo98 and @apainintheneck!

@github-actions github-actions bot added the outdated PR was locked due to age label Jan 28, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Bumping Gemfile dependencies outdated PR was locked due to age ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants