Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate, disable & delete code for Homebrew 4.2.0 #16306

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Dec 7, 2023

Comment on lines -3375 to -3376
def plist_options(options)
odisabled "plist_options", "service.require_root"
Copy link
Member Author

@Bo98 Bo98 Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the number of errors in audit CI here: it seems this deprecation didn't work and we will probably have to restart the process and figure out why.

Copy link
Member Author

@Bo98 Bo98 Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right it did work, just not for every formula because of:

formula_contents.include?(" deprecate! ") || formula_contents.include?(" disable! ")

Which doesn't really work with things that are future-deprecated like the PHP versioned formulae.

Given we have to deal with things when they get removed anyway, and the deprecation cycle of formulae is significantly longer than brew's, this check is probably not as useful as it seems.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handled the remaining formulae in Homebrew/homebrew-core#156780.

Comment on lines -146 to +153
# odeprecated "Language::Python::Virtualenv.virtualenv_create's without_pip" unless without_pip
# Limit deprecation to 3.12+ for now (or if we can't determine the version).
# Some used this argument for setuptools, which we no longer bundle since 3.12.
unless without_pip
python_version = Language::Python.major_minor_version(python)
if python_version.nil? || python_version.null? || python_version >= "3.12"
raise ArgumentError, "virtualenv_create's without_pip is deprecated starting with Python 3.12"
end
end
Copy link
Member Author

@Bo98 Bo98 Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is perhaps unusual but it's either this or don't deprecate at all I reckon. GitHub search shows 134 usages in third-party taps (and once in homebrew-core).

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. All makes sense to me so far and happy to merge whenever 💚!

@Bo98 Bo98 marked this pull request as ready for review December 11, 2023 15:43
@Bo98 Bo98 merged commit 5ee6e96 into Homebrew:master Dec 11, 2023
34 checks passed
@Bo98 Bo98 deleted the 4.2.0-deprecations branch December 11, 2023 15:44
MikeMcQuaid added a commit to Homebrew/homebrew-test-bot that referenced this pull request Dec 11, 2023
`--new-formula` was deprecated in
Homebrew/brew#16306
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Dec 13, 2023
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Dec 13, 2023
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Dec 13, 2023
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Dec 13, 2023
Bo98 pushed a commit to Homebrew/homebrew-core that referenced this pull request Dec 13, 2023
Bo98 added a commit to Homebrew/homebrew-core that referenced this pull request Dec 13, 2023
Bo98 pushed a commit to Homebrew/homebrew-core that referenced this pull request Dec 13, 2023
Bo98 pushed a commit to Homebrew/homebrew-core that referenced this pull request Dec 13, 2023
Bo98 added a commit to Homebrew/homebrew-core that referenced this pull request Dec 13, 2023
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Dec 14, 2023
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Dec 14, 2023
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Dec 14, 2023
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Dec 14, 2023
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Dec 14, 2023
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Dec 14, 2023
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Dec 14, 2023
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Dec 14, 2023
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Dec 14, 2023
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Dec 14, 2023
MikeMcQuaid added a commit to Homebrew/homebrew-core that referenced this pull request Dec 14, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants