workflows: improve setup-homebrew and API usage. #15634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
reviewed
Jul 5, 2023
MikeMcQuaid
force-pushed
the
install_from_api_setup_homebrew
branch
from
a034700
to
72a9fa1
Compare
Bo98
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Seems fine. If you can, after merging Homebrew/actions#393 try rebase/whatever to force a rerun of everything here (not just the failed ones) to make sure it all works, and there's no runtime regressions either.
Good idea 👍🏻 |
MikeMcQuaid
force-pushed
the
install_from_api_setup_homebrew
branch
from
72a9fa1
to
ef3cb34
Compare
|
|
MikeMcQuaid
force-pushed
the
install_from_api_setup_homebrew
branch
from
ef3cb34
to
c47468a
Compare
- `HOMEBREW_NO_INSTALL_FROM_API` was passed in a few places unnecessarily - Homebrew/actions#393 will change the default behaviour of setup-homebrew so let's be explicit to speed things up and avoid changes when it's merged
MikeMcQuaid
force-pushed
the
install_from_api_setup_homebrew
branch
from
c47468a
to
5121567
Compare
|
Also now installing bundler gems for some reason. |
Sorry, I missed that before auto-merge. Log link? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_APIwas passed in a few places unnecessarily