Merge pull request #18456 from Homebrew/skip-incompatible-arch

Homebrew · Sep 30, 2024 · f0513c0 · f0513c0
2 parents cdc228a + 6329db9
commit f0513c0
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/Library/Homebrew/extend/pathname.rb b/Library/Homebrew/extend/pathname.rb
@@ -469,6 +469,11 @@ def dylib?
     false
   end
 
+  sig { params(_wanted_arch: Symbol).returns(T::Boolean) }
+  def arch_compatible?(_wanted_arch)
+    true
+  end
+
   sig { returns(T::Array[String]) }
   def rpaths
     []

diff --git a/Library/Homebrew/linkage_checker.rb b/Library/Homebrew/linkage_checker.rb
@@ -115,6 +115,7 @@ def check_dylibs(rebuild_cache:)
       @keg.find do |file|
         next if file.symlink? || file.directory?
         next if !file.dylib? && !file.binary_executable? && !file.mach_o_bundle?
+        next unless file.arch_compatible?(Hardware::CPU.arch)
 
         # weakly loaded dylibs may not actually exist on disk, so skip them
         # when checking for broken linkage

diff --git a/Library/Homebrew/os/linux/elf.rb b/Library/Homebrew/os/linux/elf.rb
@@ -68,6 +68,12 @@ def arch
     end
   end
 
+  def arch_compatible?(wanted_arch)
+    return true unless elf?
+
+    wanted_arch == arch
+  end
+
   def elf_type
     return :dunno unless elf?