BD Modifications to add Storage Volume resource management #156
Conversation
| if deploymentManagerSetting["deployment_cluster_uri"] != nil { | ||
| deploymentClusterUri = utils.NewNstring(deploymentManagerSetting["deployment_cluster_uri"].(string)) | ||
| } | ||
| deploymentClusterUri := utils.NewNstring(deploymentManagerSetting["deployment_cluster_uri"].(string)) |
There was a problem hiding this comment.
var deploymentClusterUri should be deploymentClusterURI
| if deploymentManagerSetting["deployment_cluster_uri"] != nil { | ||
| deploymentClusterUri = utils.NewNstring(deploymentManagerSetting["deployment_cluster_uri"].(string)) | ||
| } | ||
| deploymentClusterUri := utils.NewNstring(deploymentManagerSetting["deployment_cluster_uri"].(string)) |
There was a problem hiding this comment.
var deploymentClusterUri should be deploymentClusterURI
|
|
||
| @output.puts <<EOF | ||
| }%% | ||
| EOF |
There was a problem hiding this comment.
Naming/HeredocDelimiterNaming: Use meaningful heredoc delimiters.
| properties.each { |x| generate_machine( x, x ) } | ||
|
|
||
| @output.puts <<EOF | ||
| }%% |
There was a problem hiding this comment.
Layout/IndentHeredoc: Use 2 spaces for indentation in a heredoc by using <<~ instead of <<.
|
|
||
| EOF | ||
|
|
||
| properties.each { |x| generate_machine( x, x ) } |
There was a problem hiding this comment.
Layout/SpaceInsideParens: Space inside parentheses detected.
| %%{ | ||
| machine #{machine_name}; | ||
|
|
||
| EOF |
There was a problem hiding this comment.
Naming/HeredocDelimiterNaming: Use meaningful heredoc delimiters.
|
|
||
| %%{ | ||
| machine #{machine_name}; | ||
|
|
There was a problem hiding this comment.
Layout/TrailingWhitespace: Trailing whitespace detected.
| desc_width -= (range_width - RANGE_WIDTH) if range_width > RANGE_WIDTH | ||
|
|
||
| if desc.size > desc_width | ||
| desc = desc[0..desc_width - 4] + "..." |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| desc_width = TOTAL_WIDTH - RANGE_WIDTH - 11 | ||
| desc_width -= (range_width - RANGE_WIDTH) if range_width > RANGE_WIDTH | ||
|
|
||
| if desc.size > desc_width |
There was a problem hiding this comment.
Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
| #raise "Invalid encoding of range #{range}: #{codes.inspect}" unless | ||
| # is_valid? range, desc, codes | ||
|
|
||
| range_width = codes.map { |a| a.size }.max |
There was a problem hiding this comment.
Style/SymbolProc: Pass &:size as an argument to map instead of a block.
|
|
||
| codes = (@encoding == :ucs4) ? to_ucs4(range) : to_utf8(range) | ||
|
|
||
| #raise "Invalid encoding of range #{range}: #{codes.inspect}" unless |
There was a problem hiding this comment.
Layout/LeadingCommentSpace: Missing space after #.
Layout/TrailingWhitespace: Trailing whitespace detected.
| @output.puts " #{name} = " | ||
| each_alpha( @chart_url, property ) do |range, desc| | ||
|
|
||
| codes = (@encoding == :ucs4) ? to_ucs4(range) : to_utf8(range) |
There was a problem hiding this comment.
Style/TernaryParentheses: Omit parentheses for ternary conditions.
| pipe = " " | ||
| @output.puts " #{name} = " | ||
| each_alpha( @chart_url, property ) do |range, desc| | ||
|
|
There was a problem hiding this comment.
Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning.
| def generate_machine( name, property ) | ||
| pipe = " " | ||
| @output.puts " #{name} = " | ||
| each_alpha( @chart_url, property ) do |range, desc| |
There was a problem hiding this comment.
Layout/SpaceInsideParens: Space inside parentheses detected.
| # Generate the state maching to stdout | ||
|
|
||
| def generate_machine( name, property ) | ||
| pipe = " " |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| ## | ||
| # Generate the state maching to stdout | ||
|
|
||
| def generate_machine( name, property ) |
There was a problem hiding this comment.
Metrics/AbcSize: Assignment Branch Condition size for generate_machine is too high. [26.87/15]
Metrics/MethodLength: Method has too many lines. [20/10]
Layout/SpaceInsideParens: Space inside parentheses detected.
| range_count = range.end - range.begin + 1 | ||
|
|
||
| sum = codes.inject(0) { |acc, elt| acc + count_codepoints(elt) } | ||
| sum == spec_count and sum == range_count |
There was a problem hiding this comment.
Style/AndOr: Use && instead of and.
| ret.flatten! | ||
| end | ||
|
|
||
| def to_utf8( range ) |
There was a problem hiding this comment.
Layout/SpaceInsideParens: Space inside parentheses detected.
| ### | ||
| # Don't generate last range if it is covered by first range | ||
|
|
||
| ret << build_range(b + "00" * left, stop) unless b == "FF" |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
|
|
||
| ### | ||
| # Don't generate last range if it is covered by first range | ||
|
|
There was a problem hiding this comment.
Layout/TrailingWhitespace: Trailing whitespace detected.
| if a.hex+1 != b.hex | ||
| max = to_hex(b.hex - 1) | ||
| max = "FF" if b == "FF" | ||
| ret << "0x#{to_hex(a.hex+1)}..0x#{max} " + "0x00..0xFF " * left |
There was a problem hiding this comment.
Layout/SpaceAroundOperators: Surrounding space missing for operator +.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
|
|
||
| if a.hex+1 != b.hex | ||
| max = to_hex(b.hex - 1) | ||
| max = "FF" if b == "FF" |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| ### | ||
| # Only generate middle range if need be. | ||
|
|
||
| if a.hex+1 != b.hex |
There was a problem hiding this comment.
Layout/SpaceAroundOperators: Surrounding space missing for operator +.
| # 0x560000 .. 0x56789A | ||
|
|
||
| ret = [] | ||
| ret << build_range(start, a + "FF" * left) |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| # Unshared prefix, end of run | ||
|
|
||
| return ["0x#{a}..0x#{b} "] if left.zero? | ||
|
|
There was a problem hiding this comment.
Layout/TrailingWhitespace: Trailing whitespace detected.
| def build_range( start, stop ) | ||
| size = start.size/2 | ||
| left = size - 1 | ||
| return [""] if size < 1 |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| end | ||
|
|
||
| def build_range( start, stop ) | ||
| size = start.size/2 |
There was a problem hiding this comment.
Layout/SpaceAroundOperators: Surrounding space missing for operator /.
| r = y << 6 | z | ||
| elsif n <= 0xefffff | ||
| x = (n >> 16) & 0x0f | ||
| y = (n >> 8) & 0x3f |
There was a problem hiding this comment.
Layout/SpaceAroundOperators: Operator >> should be surrounded by a single space.
Layout/ExtraSpacing: Unnecessary spacing detected.
| to_hex(r) | ||
| end | ||
|
|
||
| def from_utf8_enc( n ) |
There was a problem hiding this comment.
Metrics/AbcSize: Assignment Branch Condition size for from_utf8_enc is too high. [35.57/15]
Metrics/MethodLength: Method has too many lines. [21/10]
Layout/SpaceInsideParens: Space inside parentheses detected.
Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.
| elsif n <= 0x10ffff | ||
| w = 0xf0 | (n >> 18) | ||
| x = 0x80 | (n >> 12) & 0x3f | ||
| y = 0x80 | (n >> 6) & 0x3f |
There was a problem hiding this comment.
Layout/SpaceAroundOperators: Operator >> should be surrounded by a single space.
Layout/ExtraSpacing: Unnecessary spacing detected.
| r = y << 8 | z | ||
| elsif n <= 0xffff | ||
| x = 0xe0 | (n >> 12) | ||
| y = 0x80 | (n >> 6) & 0x3f |
There was a problem hiding this comment.
Layout/SpaceAroundOperators: Operator >> should be surrounded by a single space.
Layout/ExtraSpacing: Unnecessary spacing detected.
|
|
||
| UTF8_BOUNDARIES = [0x7f, 0x7ff, 0xffff, 0x10ffff] | ||
|
|
||
| def to_utf8_enc( n ) |
There was a problem hiding this comment.
Metrics/AbcSize: Assignment Branch Condition size for to_utf8_enc is too high. [40.69/15]
Metrics/MethodLength: Method has too many lines. [20/10]
Layout/SpaceInsideParens: Space inside parentheses detected.
Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.
| # 0x800 - 0xffff -> 1110xxxx[4] 10yyyyyy[6] 10zzzzzz[6] | ||
| # 0x010000 - 0x10ffff -> 11110www[3] 10xxxxxx[6] 10yyyyyy[6] 10zzzzzz[6] | ||
|
|
||
| UTF8_BOUNDARIES = [0x7f, 0x7ff, 0xffff, 0x10ffff] |
There was a problem hiding this comment.
Style/MutableConstant: Freeze mutable objects assigned to constants.
| # 0x00 - 0x7f -> 0zzzzzzz[7] | ||
| # 0x80 - 0x7ff -> 110yyyyy[5] 10zzzzzz[6] | ||
| # 0x800 - 0xffff -> 1110xxxx[4] 10yyyyyy[6] 10zzzzzz[6] | ||
| # 0x010000 - 0x10ffff -> 11110www[3] 10xxxxxx[6] 10yyyyyy[6] 10zzzzzz[6] |
There was a problem hiding this comment.
Layout/TrailingWhitespace: Trailing whitespace detected.
| def to_ucs4( range ) | ||
| rangestr = "0x" + to_hex(range.begin) | ||
| rangestr << "..0x" + to_hex(range.end) if range.begin != range.end | ||
| [ rangestr ] |
There was a problem hiding this comment.
Layout/SpaceInsideArrayLiteralBrackets: Do not use space inside array brackets.
|
|
||
| def to_ucs4( range ) | ||
| rangestr = "0x" + to_hex(range.begin) | ||
| rangestr << "..0x" + to_hex(range.end) if range.begin != range.end |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| # UCS4 is just a straight hex conversion of the unicode codepoint. | ||
|
|
||
| def to_ucs4( range ) | ||
| rangestr = "0x" + to_hex(range.begin) |
There was a problem hiding this comment.
Layout/ExtraSpacing: Unnecessary spacing detected.
Layout/SpaceAroundOperators: Operator = should be surrounded by a single space.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| open( url ) do |file| | ||
| file.each_line do |line| | ||
| next if line =~ /^#/; | ||
| next if line !~ /; #{property} #/; |
There was a problem hiding this comment.
Style/Semicolon: Do not use semicolons to terminate expressions.
| def each_alpha( url, property ) | ||
| open( url ) do |file| | ||
| file.each_line do |line| | ||
| next if line =~ /^#/; |
There was a problem hiding this comment.
Style/Semicolon: Do not use semicolons to terminate expressions.
| # range and description. | ||
|
|
||
| def each_alpha( url, property ) | ||
| open( url ) do |file| |
There was a problem hiding this comment.
Security/Open: The use of Kernel#open is a serious security risk.
Layout/SpaceInsideParens: Space inside parentheses detected.
| # Downloads the document at url and yields every alpha line's hex | ||
| # range and description. | ||
|
|
||
| def each_alpha( url, property ) |
There was a problem hiding this comment.
Metrics/MethodLength: Method has too many lines. [14/10]
Layout/SpaceInsideParens: Space inside parentheses detected.
Layout/TrailingWhitespace: Trailing whitespace detected.
| properties = o | ||
| end | ||
| opts.on("-o", "--output FILE", "output file") do |o| | ||
| @output = File.new(o, "w+") |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| opts.on("-p", "--properties x,y,z", Array, "Properties to add to machine") do |o| | ||
| properties = o | ||
| end | ||
| opts.on("-o", "--output FILE", "output file") do |o| |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| opts.on("-m", "--machine MACHINE_NAME", "Machine name") do |o| | ||
| machine_name = o | ||
| end | ||
| opts.on("-p", "--properties x,y,z", Array, "Properties to add to machine") do |o| |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Metrics/LineLength: Line is too long. [83/80]
| opts.on("-u", "--url URL", "URL to process") do |o| | ||
| @chart_url = o | ||
| end | ||
| opts.on("-m", "--machine MACHINE_NAME", "Machine name") do |o| |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| exit | ||
| end | ||
| opts.on("-u", "--url URL", "URL to process") do |o| | ||
| @chart_url = o |
There was a problem hiding this comment.
Layout/TrailingWhitespace: Trailing whitespace detected.
| puts opts | ||
| exit | ||
| end | ||
| opts.on("-u", "--url URL", "URL to process") do |o| |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| # -o, --output Write output to file | ||
| # | ||
| # Updated by: Marty Schoch <[email protected]> | ||
| # |
There was a problem hiding this comment.
Layout/TrailingWhitespace: Trailing whitespace detected.
| @@ -0,0 +1,335 @@ | |||
| #!/usr/bin/env ruby | |||
There was a problem hiding this comment.
Lint/ScriptPermission: Script file unicode2ragel.rb doesn't have execute permission.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
|
|
||
| @output.puts <<EOF | ||
| }%% | ||
| EOF |
There was a problem hiding this comment.
Naming/HeredocDelimiterNaming: Use meaningful heredoc delimiters.
| properties.each { |x| generate_machine( x, x ) } | ||
|
|
||
| @output.puts <<EOF | ||
| }%% |
There was a problem hiding this comment.
Layout/IndentHeredoc: Use 2 spaces for indentation in a heredoc by using <<~ instead of <<.
|
|
||
| EOF | ||
|
|
||
| properties.each { |x| generate_machine( x, x ) } |
There was a problem hiding this comment.
Layout/SpaceInsideParens: Space inside parentheses detected.
Adding:
Modifies