adding support for SAS Interconnects #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnushaY1916
requested changes
Jun 25, 2019
There was a problem hiding this comment.
Can you please add an example file and also update the endpoints-support.md and change log. You can refer to this PR https://github.com/HewlettPackard/oneview-golang/pull/133/files
| Modified string `json:"modified,omitempty"` // "modified": "2018-12-03T18:26:43.335Z", | ||
| RefreshState string `json:"refreshState,omitempty"` // "refreshState": "NotRefreshing" | ||
| StateReason string `json:"stateReason,omitempty"` // "stateReason": null | ||
| InterconnectLocation SASInterconnectLocation `json:"interconnectLocation"` // "interconnectLocation": {} |
There was a problem hiding this comment.
No need to create a new Struct, InterconnectLocation struct exists in interconnect.go file. You can make use of it.
| Model string `json:"model,omitempty"` // "model": "Synergy 12Gb SAS Connection Module" | ||
| SasWWN string `json:"sasWWN,omitempty"` // "sasWWN": "50014380421BE900" | ||
| EnclosureURI utils.Nstring `json:"enclosureUri,omitempty"` // "enclosureUri": "/rest/enclosures/013645CN759000AC" | ||
| SerialNumber string `json:"serialNumber,omitempty"` // "serialNumber": "TWT732W0CY", |
There was a problem hiding this comment.
Can you please keep all the fields in alphabetical order?
| SasLogicalInterconnectURI utils.Nstring `json:"sasLogicalInterconnectUri,omitempty"` // "sasLogicalInterconnectUri": "/rest/sas-logical-interconnects/c6e17ed8-de41-4d53-aa50-2da58a0d63b8" | ||
| InterconnectTypeURI utils.Nstring `json:"interconnectTypeUri,omitempty"` //"interconnectTypeURI": "/rest/sas-interconnect-types/Synergy12GbSASConnectionModule" | ||
| PortCount int `json:"portCount,omitempty"` // "portCount": 12, | ||
| EnclosureName string `json:"enclosureName,omitempty"` // "enclosureName": "CEC" |
There was a problem hiding this comment.
EnclosureName and InitialScopeUris feilds are missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to other components (enclosures, server hardware) adding support for SAS Interconnects to be able to pull their status for example for monitoring purposes
Issues Resolved
none
Check List